isolate.py - Issue 51383003: Report all swarming and isolate fatal errors in a consistent way.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: isolate.py

Issue 51383003: Report all swarming and isolate fatal errors in a consistent way. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/swarm_client

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: isolate.py

diff --git a/isolate.py b/isolate.py

index 9ab79a8d2b19ecd391f20c160e5fc55f3ac3621a..74f8ae9a510b4114fb7d66ff901306b7b1337eae 100755

--- a/isolate.py

+++ b/isolate.py

@@ -2451,11 +2451,10 @@ def main(argv):

return dispatcher.execute(OptionParserIsolate(version=__version__), argv)

except (

ExecutionError,

+ IOError,

isolateserver.ConfigError,

isolateserver.MappingError) as e:

- sys.stderr.write('\nError: ')

- sys.stderr.write(str(e))

- sys.stderr.write('\n')

+ tools.report_error(str(e), include_traceback=True)

M-A Ruel 2013/10/29 22:42:50 You may want to handle anything then? E.g. "except

return 1

« no previous file with comments | « no previous file | isolateserver.py » ('j') | no next file with comments »