tests/run_isolated_smoke_test.py - Issue 51383003: Report all swarming and isolate fatal errors in a consistent way.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/run_isolated_smoke_test.py

Issue 51383003: Report all swarming and isolate fatal errors in a consistent way. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/swarm_client

Patch Set: make isolate_smoke_test less strict regarding exact contents of stderr Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/run_isolated_smoke_test.py

diff --git a/tests/run_isolated_smoke_test.py b/tests/run_isolated_smoke_test.py

index 45839b489557b0ee0941eaae185866a7fab851e9..49f69843bade32eb68d67cb2fca047288d4f650a 100755

--- a/tests/run_isolated_smoke_test.py

+++ b/tests/run_isolated_smoke_test.py

@@ -187,7 +187,7 @@ class RunSwarmStep(unittest.TestCase):

out, err, returncode = self._run(self._generate_args_with_hash(result_hash))

if not VERBOSE:

self.assertEqual('', out)

- self.assertEqual('No command to run\n', err)

+ self.assertIn('No command to run\n', err)

self.assertEqual(1, returncode)

actual = list_files_tree(self.cache)

self.assertEqual(sorted(expected), actual)

« no previous file with comments | « tests/isolate_smoke_test.py ('k') | utils/tools.py » ('j') | no next file with comments »