Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: run_isolated.py

Issue 51383003: Report all swarming and isolate fatal errors in a consistent way. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/swarm_client
Patch Set: make isolate_smoke_test less strict regarding exact contents of stderr Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « isolateserver.py ('k') | swarming.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: run_isolated.py
diff --git a/run_isolated.py b/run_isolated.py
index dab90b32fbe63721a64499452e99befa94fb67f3..54f36d4c597cc99cfcc1e9d22259e925caf99213 100755
--- a/run_isolated.py
+++ b/run_isolated.py
@@ -497,7 +497,7 @@ def run_tha_test(isolated_hash, storage, cache, algo, outdir):
os_flavor=get_flavor(),
require_command=True)
except isolateserver.ConfigError as e:
- print >> sys.stderr, str(e)
+ tools.report_error(e)
return 1
if settings.read_only:
@@ -517,7 +517,7 @@ def run_tha_test(isolated_hash, storage, cache, algo, outdir):
with tools.Profiler('RunTest'):
return subprocess.call(settings.command, cwd=cwd, env=env)
except OSError:
- print >> sys.stderr, 'Failed to run %s; cwd=%s' % (settings.command, cwd)
+ tools.report_error('Failed to run %s; cwd=%s' % (settings.command, cwd))
return 1
finally:
if outdir:
@@ -602,6 +602,7 @@ def main():
options.isolated or options.hash, storage, cache, algo, outdir)
except Exception as e:
# Make sure any exception is logged.
+ tools.report_error(e)
logging.exception(e)
return 1
« no previous file with comments | « isolateserver.py ('k') | swarming.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698