tools/metrics/histograms/extract_histograms.py - Issue 513803005: Remove obsolete fieldtrial related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/extract_histograms.py

Issue 513803005: Remove obsolete fieldtrial related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/extract_histograms.py

diff --git a/tools/metrics/histograms/extract_histograms.py b/tools/metrics/histograms/extract_histograms.py

index 04a61d1bc74c2add313ec735fa79963b25a0739e..c2211c89b3a04c24cb58da614222338541919e58 100644

--- a/tools/metrics/histograms/extract_histograms.py

+++ b/tools/metrics/histograms/extract_histograms.py

@@ -42,9 +42,9 @@ XML below will generate the following five histograms:

<histogram_suffixes_list>

<histogram_suffixes name="BrowserType">

- <group name="Chrome"/>

- <group name="IE"/>

- <group name="Firefox"/>

+ <suffix name="Chrome"/>

+ <suffix name="IE"/>

+ <suffix name="Firefox"/>

<affected-histogram name="HistogramEnum"/>

</histogram_suffixes>

@@ -307,15 +307,9 @@ def _UpdateHistogramsWithSuffixes(tree, histograms):

"""

have_errors = False

- # TODO(yiyaoliu): Remove this part after fieldtrial is not used any more.

- if tree.getElementsByTagName('histogram_suffixes'):

- histogram_suffix_tag = 'histogram_suffixes'

- suffix_tag = 'suffix'

- with_tag = 'with-suffix'

- else:

- histogram_suffix_tag = 'fieldtrial'

- suffix_tag = 'group'

- with_tag = 'with-group'

+ histogram_suffix_tag = 'histogram_suffixes'

+ suffix_tag = 'suffix'

+ with_tag = 'with-suffix'

# Verify order of histogram_suffixes fields first.

last_name = None

« no previous file with comments | « no previous file | tools/metrics/histograms/pretty_print.py » ('j') | no next file with comments »