Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 5138001: Remove obsolete files. (Closed)

Created:
10 years, 1 month ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
Tan Gao, adlr, anush
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Remove obsolete files. These aren't used and have become unsynced with the functioning ones. BUG=9274 TEST=no Change-Id: I75755b2d3d9e35bab85fd93c6692bbe30a960cdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -547 lines) Patch
D mod_for_factory_scripts/200patchInitScript View 1 chunk +0 lines, -105 lines 0 comments Download
D mod_for_factory_scripts/300modifyDescription View 1 chunk +0 lines, -9 lines 0 comments Download
D mod_for_factory_scripts/400configAutotest View 1 chunk +0 lines, -20 lines 0 comments Download
D mod_for_factory_scripts/500populateQualDbs View 1 chunk +0 lines, -29 lines 0 comments Download
D mod_for_factory_scripts/510populateGbbFiles View 1 chunk +0 lines, -20 lines 0 comments Download
D mod_for_factory_scripts/factory_setup.sh View 1 chunk +0 lines, -13 lines 0 comments Download
D mod_for_test_scripts/000recordRootFsSize View 1 chunk +0 lines, -22 lines 0 comments Download
D mod_for_test_scripts/001changeBuildName View 1 chunk +0 lines, -12 lines 0 comments Download
D mod_for_test_scripts/002enableDumps View 1 chunk +0 lines, -12 lines 0 comments Download
D mod_for_test_scripts/100setupTestingInterface View 1 chunk +0 lines, -132 lines 0 comments Download
D mod_for_test_scripts/200disableIdleSuspend View 1 chunk +0 lines, -8 lines 0 comments Download
D mod_for_test_scripts/300changePassword View 1 chunk +0 lines, -14 lines 0 comments Download
D mod_for_test_scripts/350addTestAuthKeys View 1 chunk +0 lines, -20 lines 0 comments Download
D mod_for_test_scripts/400modifyUpstart View 1 chunk +0 lines, -11 lines 0 comments Download
D mod_for_test_scripts/700enableAutoxLogin View 1 chunk +0 lines, -10 lines 0 comments Download
D mod_for_test_scripts/710enableAuthTesting View 1 chunk +0 lines, -55 lines 0 comments Download
D mod_for_test_scripts/750enableExternalExtensions View 1 chunk +0 lines, -15 lines 0 comments Download
D mod_for_test_scripts/ssh_keys/testing_rsa View 1 chunk +0 lines, -27 lines 0 comments Download
D mod_for_test_scripts/ssh_keys/testing_rsa.pub View 1 chunk +0 lines, -1 line 0 comments Download
D mod_for_test_scripts/test_setup.sh View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nick Sanders
Looks like this refactor never happened, we shouldn't have a set of stale duplicate files ...
10 years, 1 month ago (2010-11-17 02:18:58 UTC) #1
anush
+zbehan Zdenek just rejoined us this week and is getting setup. His first task is ...
10 years, 1 month ago (2010-11-17 03:32:50 UTC) #2
Nick Sanders
> However re-adding it shouldn't be a problem either. That's fine. Since the files are ...
10 years, 1 month ago (2010-11-17 04:02:53 UTC) #3
anush
10 years, 1 month ago (2010-11-17 04:09:14 UTC) #4
LGTM

On Tue, Nov 16, 2010 at 8:02 PM,  <nsanders@chromium.org> wrote:
>> However re-adding it shouldn't be a problem either.
>
> That's fine. Since the files are stale now, it's probably safest to remove
> them,
> and simply re-add the up-to-date files when the refactor is ready. I'd like
> to
> avoid any situation where these old files are turned on and break the build.
>
>
> http://codereview.chromium.org/5138001/
>

Powered by Google App Engine
This is Rietveld 408576698