Bring up of ImageService.

Bring up of ImageService.

ImageService is an abstract superclass that will have subclasses
for each mobile platform. This class stores a salient image for
a bookmark which is removed when the bookmark node is deleted.

BUG=None

Committed: https://crrev.com/eefc52bd9cb4ceb4d007230a49445e038e118c2f
Cr-Commit-Position: refs/heads/master@{#292596}

[noyau (Ping after 24h), 2014-08-27 14:44:29]

noyau@chromium.org changed reviewers:
+ blundell@chromium.org
- blundell@google.com

[blundell, 2014-08-27 14:45:57]

lgtm

[noyau (Ping after 24h), 2014-08-27 15:05:41]

Patchset #2 (id:20001) has been deleted

[noyau (Ping after 24h), 2014-08-27 15:05:47]

The CQ bit was checked by noyau@chromium.org

[commit-bot: I haz the power, 2014-08-27 15:06:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noyau@chromium.org/513793002/1

[commit-bot: I haz the power, 2014-08-27 16:06:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-27 16:10:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 16:10:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[noyau (Ping after 24h), 2014-08-28 10:39:08]

noyau@chromium.org changed reviewers:
+ wtc@chromium.org

[noyau (Ping after 24h), 2014-08-28 10:39:08]

+wtc@ for the addition of the dependency on net in DEPS.

[wtc, 2014-08-28 23:45:50]

Patch set 1 LGTM.

https://codereview.chromium.org/513793002/diff/1/components/enhanced_bookmark...
File components/enhanced_bookmarks/bookmark_image_service.cc (right):

https://codereview.chromium.org/513793002/diff/1/components/enhanced_bookmark...
components/enhanced_bookmarks/bookmark_image_service.cc:134:
net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,

If we're passing a hardcoded value here, does RetrieveSalientImage really need
the 'referrer_policy' parameter?

[noyau (Ping after 24h), 2014-08-29 08:44:01]

https://codereview.chromium.org/513793002/diff/1/components/enhanced_bookmark...
File components/enhanced_bookmarks/bookmark_image_service.cc (right):

https://codereview.chromium.org/513793002/diff/1/components/enhanced_bookmark...
components/enhanced_bookmarks/bookmark_image_service.cc:134:
net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,
On 2014/08/28 23:45:50, wtc wrote:
> 
> If we're passing a hardcoded value here, does RetrieveSalientImage really need
> the 'referrer_policy' parameter?

RetrieveSalientImage() is protected and also called by the iOS specific subclass
(not yet in Chromium, the web layer has to land first) with the proper referrer
policy. RetrieveSalientImageForPageUrl() is called when the URL for the image
has been gatherer via sync, so the request is out of the blue, so this default
referrer policy is the proper one. The other way to get a URL is to extract it
from the page you just bookmarked or visited. As  there is no access to WebKit
in iOS the only way to retrieve the image then is to do a request, which is done
with RetrieveSalientImage() and in that case the referrer information is derived
from the page itself.

[noyau (Ping after 24h), 2014-08-29 08:44:05]

The CQ bit was checked by noyau@chromium.org

[commit-bot: I haz the power, 2014-08-29 08:45:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noyau@chromium.org/513793002/1

[commit-bot: I haz the power, 2014-08-29 09:11:58]

Committed patchset #1 (id:1) as fc9efd009cedd04c1c2420ac8617d1385a279308

[commit-bot: I haz the power, 2014-09-10 03:07:20]

Patchset 1 (id:??) landed as
https://crrev.com/eefc52bd9cb4ceb4d007230a49445e038e118c2f
Cr-Commit-Position: refs/heads/master@{#292596}