Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: LayoutTests/fast/forms/color/input-color-onchange-event.html

Issue 513783002: Dispatch change event for input type=color when colorpicker is closed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Mac test fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/color/input-color-onchange-event.html
diff --git a/LayoutTests/fast/forms/color/input-color-onchange-event.html b/LayoutTests/fast/forms/color/input-color-onchange-event.html
index d0f53acdcf599021d928e8599eaec3144744d8a7..16cf2a21950f7a38b9f4f9ada46873c84bee2094 100644
--- a/LayoutTests/fast/forms/color/input-color-onchange-event.html
+++ b/LayoutTests/fast/forms/color/input-color-onchange-event.html
@@ -20,8 +20,11 @@ input.style.top = '0';
input.style.width = '20px';
input.style.height = '20px';
+var onChange = 0;
+
input.onchange = function() {
debug("value changed to " + input.value);
+ onChange++;
};
eventSender.mouseMoveTo(10, 10);
@@ -34,10 +37,19 @@ shouldThrow("internals.selectColorInColorChooser(document, '#ff0000');");
// input.onchange should be called
internals.selectColorInColorChooser(input, '#ff0000');
+internals.endColorChooser(input);
keishi 2014/09/17 08:15:54 Ditto. No need to add this.
Habib Virji 2014/09/17 08:30:42 Added as line 26 above, will not be printed about
keishi 2014/09/18 03:50:55 We don't have a test for input events so I think w
Habib Virji 2014/09/18 12:42:05 Done.
// input.onchange should not be called
internals.selectColorInColorChooser(input, '#ff0000');
-
+internals.endColorChooser(input);
shouldBe('input.value', '"#ff0000"');
+
+debug('Change event is only dispatched, when color chooser is closed');
+onChange = 0;
+internals.selectColorInColorChooser(input, '#ff0002');
+shouldBe('onChange', '0');
+internals.endColorChooser(input);
+shouldBe('onChange', '1');
+
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698