Dispatch change event for input type=color when colorpicker is closed

Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 1464 matching lines @@
 }
 
 void HTMLInputElement::selectColorInColorChooser(const Color& color)
 {
     // FIXME: Remove type check and static_cast.
     if (type() != InputTypeNames::color)
         return;
     static_cast<ColorInputType*>(m_inputType.get())->didChooseColor(color);
 }
 
+void HTMLInputElement::endColorChooser()
+{
+    m_inputType->didEndChooser();

[keishi, 2014/09/18 13:16:01]

nit: Now I realize this seems unfortunate.
I see the name endColorChooser is already used for the method that closes the
chooser from blink,
and didEndChooser is collides with the method in ColorChooserClient.

Maybe it makes sense to call the methods on ColorChooserClient directly, because
we are trying to act as a fake ColorChooser.
if (ColorChooserClient* client = m_inputType->colorChooserClient())
  client->didEndChooser();

[Habib Virji, 2014/09/18 14:54:26]

This does not hold true, " ColorChooserClient* client =
m_inputType->colorChooserClient()" as inputType does not hold reference to
colorChooserClient().  

I suppose it is better to either use static_cast solution or use inputType
solution. 

[keishi, 2014/09/19 03:04:12]

I was thinking, ColorInputType is a ColorChooserClient, so
InputType::colorChooserClient could return null and
ColorInputType::colorChooserClient could return this.

[Habib Virji, 2014/09/19 09:15:56]

Sorry, still not clear. 

Yes ColorInputType is derived from ColorChooserClient. 

--> ColorInputType::colorChooserClient 
This does not hold as there is no member function with colorChooserClient. 

--> InputType::colorChooserClient
Does not hold as this is an independent client associated only with
ColorInputType. It will not compile.

[keishi, 2014/09/22 09:58:36]

Yes I am proposing that you add it.
InputType::colorChooserClient will be a virtual method that will be overridden
in ColorInputType.

Something like this:
ColorChooserClient* InputType::colorChooserClient() { return 0; }
ColorChooserClient* ColorInputType::colorChooserClient() OVERRIDE { return this;
}

[Habib Virji, 2014/09/22 13:44:39]

Done.

+}
+
 HTMLElement* HTMLInputElement::list() const
 {
     return dataList();
 }
 
 HTMLDataListElement* HTMLInputElement::dataList() const
 {
     if (!m_hasNonEmptyList)
         return 0;
 
@@ skipping 299 matching lines @@
 {
     listAttributeTargetChanged();
 }
 
 AXObject* HTMLInputElement::popupRootAXObject()
 {
     return m_inputTypeView->popupRootAXObject();
 }
 
 } // namespace