Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 513783002: Dispatch change event for input type=color when colorpicker is closed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Mac test fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 1464 matching lines...) Expand 10 before | Expand all | Expand 10 after
1475 } 1475 }
1476 1476
1477 void HTMLInputElement::selectColorInColorChooser(const Color& color) 1477 void HTMLInputElement::selectColorInColorChooser(const Color& color)
1478 { 1478 {
1479 // FIXME: Remove type check and static_cast. 1479 // FIXME: Remove type check and static_cast.
1480 if (type() != InputTypeNames::color) 1480 if (type() != InputTypeNames::color)
1481 return; 1481 return;
1482 static_cast<ColorInputType*>(m_inputType.get())->didChooseColor(color); 1482 static_cast<ColorInputType*>(m_inputType.get())->didChooseColor(color);
1483 } 1483 }
1484 1484
1485 void HTMLInputElement::endColorChooser()
1486 {
1487 // FIXME: Remove type check and static_cast.
1488 if (type() != InputTypeNames::color)
keishi 2014/09/17 08:15:54 We decided not to add any more if statements that
Habib Virji 2014/09/17 08:30:42 Ok, will make a change and push in new patch.
Habib Virji 2014/09/18 12:42:05 Done.
1489 return;
1490 static_cast<ColorInputType*>(m_inputType.get())->didEndChooser();
1491 }
1492
1485 HTMLElement* HTMLInputElement::list() const 1493 HTMLElement* HTMLInputElement::list() const
1486 { 1494 {
1487 return dataList(); 1495 return dataList();
1488 } 1496 }
1489 1497
1490 HTMLDataListElement* HTMLInputElement::dataList() const 1498 HTMLDataListElement* HTMLInputElement::dataList() const
1491 { 1499 {
1492 if (!m_hasNonEmptyList) 1500 if (!m_hasNonEmptyList)
1493 return 0; 1501 return 0;
1494 1502
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
1794 { 1802 {
1795 listAttributeTargetChanged(); 1803 listAttributeTargetChanged();
1796 } 1804 }
1797 1805
1798 AXObject* HTMLInputElement::popupRootAXObject() 1806 AXObject* HTMLInputElement::popupRootAXObject()
1799 { 1807 {
1800 return m_inputTypeView->popupRootAXObject(); 1808 return m_inputTypeView->popupRootAXObject();
1801 } 1809 }
1802 1810
1803 } // namespace 1811 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698