SIMD shuffle API changes

runtime/vm/flow_graph_optimizer.cc

Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index 2c384794d5e643003fdeca29f07b4df069b31d3d..cbfae7c7a42dcc60b17e19f1fa19de19ec886526 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -1692,10 +1692,18 @@ bool FlowGraphOptimizer::InlineFloat32x4Getter(InstanceCallInstr* call,
                 call->env(),
                 call);
   intptr_t mask = 0;
-  if (getter == MethodRecognizer::kFloat32x4Shuffle) {
+  if ((getter == MethodRecognizer::kFloat32x4Shuffle) ||
+      (getter == MethodRecognizer::kFloat32x4ShuffleMix)) {
     // Extract shuffle mask.
-    ASSERT(call->ArgumentCount() == 2);
-    Definition* mask_definition = call->ArgumentAt(1);
+    Definition* mask_definition = NULL;
+    if (getter == MethodRecognizer::kFloat32x4Shuffle) {
+      ASSERT(call->ArgumentCount() == 2);
+      mask_definition = call->ArgumentAt(1);
+    } else {
+      ASSERT(getter == MethodRecognizer::kFloat32x4ShuffleMix);
+      ASSERT(call->ArgumentCount() == 3);
+      mask_definition = call->ArgumentAt(2);
+    }
     if (!mask_definition->IsConstant()) {
       // Not a constant.
       return false;
@@ -1721,13 +1729,22 @@ bool FlowGraphOptimizer::InlineFloat32x4Getter(InstanceCallInstr* call,
         call->deopt_id());
     ReplaceCall(call, instr);
     return true;
+  } else if (getter == MethodRecognizer::kFloat32x4ShuffleMix) {
+    Simd32x4ShuffleMixInstr* instr = new Simd32x4ShuffleMixInstr(
+        getter,
+        new Value(call->ArgumentAt(0)),
+        new Value(call->ArgumentAt(1)),
+        mask,
+        call->deopt_id());
+    ReplaceCall(call, instr);
+    return true;
   } else {
     ASSERT((getter == MethodRecognizer::kFloat32x4Shuffle)  ||
            (getter == MethodRecognizer::kFloat32x4ShuffleX) ||
            (getter == MethodRecognizer::kFloat32x4ShuffleY) ||
            (getter == MethodRecognizer::kFloat32x4ShuffleZ) ||
            (getter == MethodRecognizer::kFloat32x4ShuffleW));
-    Float32x4ShuffleInstr* instr = new Float32x4ShuffleInstr(
+    Simd32x4ShuffleInstr* instr = new Simd32x4ShuffleInstr(
         getter,
         new Value(call->ArgumentAt(0)),
         mask,
@@ -1751,6 +1768,37 @@ bool FlowGraphOptimizer::InlineUint32x4Getter(InstanceCallInstr* call,
                 call->deopt_id(),
                 call->env(),
                 call);
+  intptr_t mask = 0;
+  if ((getter == MethodRecognizer::kUint32x4Shuffle) ||
+      (getter == MethodRecognizer::kUint32x4ShuffleMix)) {
+    // Extract shuffle mask.
+    Definition* mask_definition = NULL;
+    if (getter == MethodRecognizer::kUint32x4Shuffle) {
+      ASSERT(call->ArgumentCount() == 2);
+      mask_definition = call->ArgumentAt(1);
+    } else {
+      ASSERT(getter == MethodRecognizer::kUint32x4ShuffleMix);
+      ASSERT(call->ArgumentCount() == 3);
+      mask_definition = call->ArgumentAt(2);
+    }
+    if (!mask_definition->IsConstant()) {
+      // Not a constant.

[srdjan, 2013/11/01 05:51:41]

This comment is redundant, I think.

[Cutch, 2013/11/01 07:06:30]

Done.

+      return false;
+    }
+    ASSERT(mask_definition->IsConstant());
+    ConstantInstr* constant_instruction = mask_definition->AsConstant();
+    const Object& constant_mask = constant_instruction->value();
+    if (!constant_mask.IsSmi()) {
+      // Not a smi.

[srdjan, 2013/11/01 05:51:41]

Ditto

[Cutch, 2013/11/01 07:06:30]

Done.

+      return false;
+    }
+    ASSERT(constant_mask.IsSmi());
+    mask = Smi::Cast(constant_mask).Value();
+    if (mask < 0 || mask > 255) {

[srdjan, 2013/11/01 05:51:41]

Add parentheses.

[Cutch, 2013/11/01 07:06:30]

Done.

+      // Not a valid mask.
+      return false;
+    }
+  }
   if (getter == MethodRecognizer::kUint32x4GetSignMask) {
     Simd32x4GetSignMaskInstr* instr = new Simd32x4GetSignMaskInstr(
         getter,
@@ -1758,6 +1806,23 @@ bool FlowGraphOptimizer::InlineUint32x4Getter(InstanceCallInstr* call,
         call->deopt_id());
     ReplaceCall(call, instr);
     return true;
+  } else if (getter == MethodRecognizer::kUint32x4ShuffleMix) {
+    Simd32x4ShuffleMixInstr* instr = new Simd32x4ShuffleMixInstr(
+        getter,
+        new Value(call->ArgumentAt(0)),
+        new Value(call->ArgumentAt(1)),
+        mask,
+        call->deopt_id());
+    ReplaceCall(call, instr);
+    return true;
+  } else if (getter == MethodRecognizer::kUint32x4Shuffle) {
+    Simd32x4ShuffleInstr* instr = new Simd32x4ShuffleInstr(
+        getter,
+        new Value(call->ArgumentAt(0)),
+        mask,
+        call->deopt_id());
+    ReplaceCall(call, instr);
+    return true;
   } else {
     Uint32x4GetFlagInstr* instr = new Uint32x4GetFlagInstr(
         getter,
@@ -2320,26 +2385,6 @@ bool FlowGraphOptimizer::TryInlineFloat32x4Method(
       ReplaceCall(call, minmax);
       return true;
     }
-    case MethodRecognizer::kFloat32x4WithZWInXY:
-    case MethodRecognizer::kFloat32x4InterleaveXY:
-    case MethodRecognizer::kFloat32x4InterleaveZW:
-    case MethodRecognizer::kFloat32x4InterleaveXYPairs:
-    case MethodRecognizer::kFloat32x4InterleaveZWPairs: {
-      Definition* left = call->ArgumentAt(0);
-      Definition* right = call->ArgumentAt(1);
-      // Type check left.
-      AddCheckClass(left,
-                    ICData::ZoneHandle(
-                        call->ic_data()->AsUnaryClassChecksForArgNr(0)),
-                    call->deopt_id(),
-                    call->env(),
-                    call);
-      Float32x4TwoArgShuffleInstr* two_arg_shuffle =
-          new Float32x4TwoArgShuffleInstr(recognized_kind, new Value(left),
-                                          new Value(right), call->deopt_id());
-      ReplaceCall(call, two_arg_shuffle);
-      return true;
-    }
     case MethodRecognizer::kFloat32x4Scale: {
       Definition* left = call->ArgumentAt(0);
       Definition* right = call->ArgumentAt(1);
@@ -2429,6 +2474,7 @@ bool FlowGraphOptimizer::TryInlineFloat32x4Method(
       ReplaceCall(call, clamp);
       return true;
     }
+    case MethodRecognizer::kFloat32x4ShuffleMix:
     case MethodRecognizer::kFloat32x4Shuffle: {
       return InlineFloat32x4Getter(call, recognized_kind);
     }
@@ -2446,6 +2492,8 @@ bool FlowGraphOptimizer::TryInlineUint32x4Method(
   }
   ASSERT(call->HasICData());
   switch (recognized_kind) {
+    case MethodRecognizer::kUint32x4ShuffleMix:
+    case MethodRecognizer::kUint32x4Shuffle:
     case MethodRecognizer::kUint32x4GetFlagX:
     case MethodRecognizer::kUint32x4GetFlagY:
     case MethodRecognizer::kUint32x4GetFlagZ:
@@ -6885,7 +6933,13 @@ void ConstantPropagator::VisitFloat32x4Constructor(
 }
 
 
-void ConstantPropagator::VisitFloat32x4Shuffle(Float32x4ShuffleInstr* instr) {
+void ConstantPropagator::VisitSimd32x4Shuffle(Simd32x4ShuffleInstr* instr) {
+  SetValue(instr, non_constant_);
+}
+
+
+void ConstantPropagator::VisitSimd32x4ShuffleMix(
+    Simd32x4ShuffleMixInstr* instr) {
   SetValue(instr, non_constant_);
 }
 
@@ -6948,12 +7002,6 @@ void ConstantPropagator::VisitFloat32x4ToUint32x4(
 }
 
 
-void ConstantPropagator::VisitFloat32x4TwoArgShuffle(
-    Float32x4TwoArgShuffleInstr* instr) {
-  SetValue(instr, non_constant_);
-}
-
-
 void ConstantPropagator::VisitUint32x4BoolConstructor(
     Uint32x4BoolConstructorInstr* instr) {
   SetValue(instr, non_constant_);