Add pixel readback to page popup

public/platform/WebCompositeAndReadbackAsyncCallback.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebCompositeAndReadbackAsyncCallback_h
 #define WebCompositeAndReadbackAsyncCallback_h
 
+#include "public/platform/WebPoint.h"
+
 class SkBitmap;
 
 namespace blink {
 
 class WebCompositeAndReadbackAsyncCallback {
 public:
     virtual void didCompositeAndReadback(const SkBitmap&) = 0;
+    void setIsPopup(bool isPopup) { m_isPopup = isPopup; };

[tkent, 2014/09/01 05:37:03]

Because this is a public API, please write comments on each of functions.  e.g.
Who should call the function, what happens by calling it, etc.

[jamesr, 2014/09/02 19:09:29]

nothing in platform/ should know or care about what a popup is. why would this
code need to be different from the normal readback paths?

[keishi, 2014/09/04 13:16:20]

Removed. I changed it so I don't stick these data into the callback here.

+    bool isPopup() { return m_isPopup; }
+    void setReadbackPosition(const WebPoint& position) { m_position = position; };
+    WebPoint& readbackPosition() { return m_position; }
+
+private:
+    bool m_isPopup;
+    WebPoint m_position;
 };
 
 } // namespace blink
 
 #endif // WebCompositeAndReadbackAsyncCallback_h