DevTools: NetworkPanel: add "Connection Id" column.

DevTools: NetworkPanel: add "Connection Id" column.

Developers can use this column to see what resources share connection.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181461

[eustas, 2014-08-27 08:26:32]

eustas@chromium.org changed reviewers:
+ vsevik@chromium.org

[vsevik, 2014-08-27 09:16:19]

I don't understand what connection id is and what value knowing it gives to
developers

[eustas, 2014-08-27 09:34:17]

On 2014/08/27 09:16:19, vsevik wrote:
> I don't understand what connection id is and what value knowing it gives to
> developers

Connection Id is identifier that is the same for requests that use the same
network connection.
Usually, those requests avoid additional network round-trip overhead, but they
are sequenced.

[vsevik, 2014-08-27 09:44:16]

vsevik@chromium.org changed reviewers:
+ paulirish@chromium.org

[paulirish, 2014-09-05 01:15:12]

knowing connectionID helps indicate that a TCP connection was reused instead of
handshaking and establishing a new one.
it's RTT cost plus TCP slowstart means established connections send data faster.

Exposing just the ID is not going to be too useful, but we can make an improved
visualizatino around it nicely.

[vsevik, 2014-09-05 05:23:33]

lgtm, but please add a scale information as Paul suggests

[vsevik, 2014-09-05 05:39:34]

Please disregard my last comment but still lgtm.

[eustas, 2014-09-05 06:07:10]

On 2014/09/05 01:15:12, paulirish wrote:
> Exposing just the ID is not going to be too useful, but we can make an
improved
> visualizatino around it nicely.

I'm working on "Network Timeline Overview". It will both visualize connection id
and help developers concentrate on page load waterfall...

[eustas, 2014-09-05 06:07:14]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-09-05 06:08:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/513703002/1

[commit-bot: I haz the power, 2014-09-05 06:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 06:08:10]

Failed to apply patch for Source/devtools/front_end/network/NetworkPanel.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/network/NetworkPanel.js
  Hunk #3 succeeded at 364 (offset -1 lines).
  Hunk #5 FAILED at 2549.
  1 out of 5 hunks FAILED -- saving rejects to file
Source/devtools/front_end/network/NetworkPanel.js.rej

Patch:       Source/devtools/front_end/network/NetworkPanel.js
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js
b/Source/devtools/front_end/network/NetworkPanel.js
index
3cb66470e0bf77c7abc4d830799e4d50f5247f06..44c1ca812a29456782587a96874ada489547b062
100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -90,7 +90,7 @@ WebInspector.NetworkLogView = function(filterBar,
coulmnsVisibilitySetting)
 WebInspector.NetworkLogView.HTTPSchemas = {"http": true, "https": true, "ws":
true, "wss": true};
 WebInspector.NetworkLogView._responseHeaderColumns = ["Cache-Control",
"Connection", "Content-Encoding", "Content-Length", "ETag", "Keep-Alive",
"Last-Modified", "Server", "Vary"];
 WebInspector.NetworkLogView.defaultColumnsVisibility = {
-    method: true, status: true, scheme: false, domain: false, remoteAddress:
false, type: true, initiator: true, cookies: false, setCookies: false, size:
true, time: true,
+    method: true, status: true, scheme: false, domain: false, remoteAddress:
false, type: true, initiator: true, cookies: false, setCookies: false, size:
true, time: true, connectionId: false,
     "Cache-Control": false, "Connection": false, "Content-Encoding": false,
"Content-Length": false, "ETag": false, "Keep-Alive": false, "Last-Modified":
false, "Server": false, "Vary": false
 };
 WebInspector.NetworkLogView._defaultRefreshDelay = 500;
@@ -124,6 +124,7 @@ WebInspector.NetworkLogView._columnTitles = {
     "setCookies": WebInspector.UIString("Set-Cookies"),
     "size": WebInspector.UIString("Size"),
     "time": WebInspector.UIString("Time"),
+    "connectionId": WebInspector.UIString("Connection Id"),
     "timeline": WebInspector.UIString("Timeline"),
 
     // Response header columns
@@ -364,6 +365,13 @@ WebInspector.NetworkLogView.prototype = {
             align: WebInspector.DataGrid.Align.Right
         });
 
+        columns.push({
+            id: "connectionId",
+            title: WebInspector.NetworkLogView._columnTitles["connectionId"],
+            sortable: true,
+            weight: 6
+        });
+
         var responseHeaderColumns =
WebInspector.NetworkLogView._responseHeaderColumns;
         for (var i = 0; i < responseHeaderColumns.length; ++i) {
             var headerName = responseHeaderColumns[i];
@@ -473,6 +481,7 @@ WebInspector.NetworkLogView.prototype = {
         this._sortingFunctions.setCookies =
WebInspector.NetworkDataGridNode.ResponseCookiesCountComparator;
         this._sortingFunctions.size =
WebInspector.NetworkDataGridNode.SizeComparator;
         this._sortingFunctions.time =
WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null,
"duration", false);
+        this._sortingFunctions.connectionId =
WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null,
"connectionId", false);
         this._sortingFunctions.timeline =
WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null,
"startTime", false);
         this._sortingFunctions.startTime =
WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null,
"startTime", false);
         this._sortingFunctions.endTime =
WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "endTime",
false);
@@ -2540,6 +2549,7 @@ WebInspector.NetworkDataGridNode.prototype = {
         case "remoteAddress":
cell.setTextAndTitle(this._request.remoteAddress()); break;
         case "cookies":
cell.setTextAndTitle(this._arrayLength(this._request.requestCookies)); break;
         case "setCookies":
cell.setTextAndTitle(this._arrayLength(this._request.responseCookies)); break;
+        case "connectionId": cell.setTextAndTitle(this._request.connectionId);
break;
         case "type": this._renderTypeCell(cell); break;
         case "initiator": this._renderInitiatorCell(cell); break;
         case "size": this._renderSizeCell(cell); break;

[eustas, 2014-09-05 08:32:00]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-09-05 08:32:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/513703002/20001

[commit-bot: I haz the power, 2014-09-05 10:04:05]

Committed patchset #2 (id:20001) as 181461