Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4649)

Unified Diff: chrome/common/render_messages.cc

Issue 5137004: Autofill: Prefer maxLength to size attribute for form filling heuristics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Denitting Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/renderer/form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/render_messages.cc
diff --git a/chrome/common/render_messages.cc b/chrome/common/render_messages.cc
index e6d31262d9c773c4683154556510f82b99927245..eb1e19d3f9ba68210857eb994569c9e452239858 100644
--- a/chrome/common/render_messages.cc
+++ b/chrome/common/render_messages.cc
@@ -94,20 +94,20 @@ void ParamTraits<webkit_glue::FormField>::Write(Message* m,
WriteParam(m, p.name());
WriteParam(m, p.value());
WriteParam(m, p.form_control_type());
- WriteParam(m, p.size());
+ WriteParam(m, p.max_length());
WriteParam(m, p.option_strings());
}
bool ParamTraits<webkit_glue::FormField>::Read(const Message* m, void** iter,
param_type* p) {
string16 label, name, value, form_control_type;
- int size = 0;
+ int max_length = 0;
std::vector<string16> options;
bool result = ReadParam(m, iter, &label);
result = result && ReadParam(m, iter, &name);
result = result && ReadParam(m, iter, &value);
result = result && ReadParam(m, iter, &form_control_type);
- result = result && ReadParam(m, iter, &size);
+ result = result && ReadParam(m, iter, &max_length);
result = result && ReadParam(m, iter, &options);
if (!result)
return false;
@@ -116,7 +116,7 @@ bool ParamTraits<webkit_glue::FormField>::Read(const Message* m, void** iter,
p->set_name(name);
p->set_value(value);
p->set_form_control_type(form_control_type);
- p->set_size(size);
+ p->set_max_length(max_length);
p->set_option_strings(options);
return true;
}
« no previous file with comments | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/renderer/form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698