chrome/renderer/form_manager.cc - Issue 5137004: Autofill: Prefer maxLength to size attribute for form filling heuristics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/form_manager.cc

Issue 5137004: Autofill: Prefer maxLength to size attribute for form filling heuristics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix RenderViewTest browser tests Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/form_manager.cc

diff --git a/chrome/renderer/form_manager.cc b/chrome/renderer/form_manager.cc

index 9855a09b35234eca5a3ea14aad4981ed021ac7b8..d8c931bf28d55e2e7b8e9647f1675c08b7253e96 100644

--- a/chrome/renderer/form_manager.cc

+++ b/chrome/renderer/form_manager.cc

@@ -310,7 +310,7 @@ void FormManager::WebFormControlElementToFormField(

if (element.formControlType() == WebString::fromUTF8("text")) {

const WebInputElement& input_element = element.toConst<WebInputElement>();

- field->set_size(input_element.size());

+ field->set_max_length(input_element.maxLength());

}

if (!(extract_mask & EXTRACT_VALUE))

« no previous file with comments | « chrome/common/render_messages.cc ('k') | chrome/renderer/form_manager_browsertest.cc » ('j') | chrome/renderer/render_view_browsertest.cc » ('J')