Autofill: Prefer maxLength to size attribute for form filling heuristics.

chrome/renderer/render_view_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 
 #include "app/keyboard_codes.h"
 #include "base/file_util.h"
 #include "base/shared_memory.h"
 #include "base/string_util.h"
@@ skipping 20 matching lines @@
 
 using WebKit::WebDocument;
 using WebKit::WebFrame;
 using WebKit::WebInputElement;
 using WebKit::WebString;
 using WebKit::WebTextDirection;
 using WebKit::WebURLError;
 using webkit_glue::FormData;
 using webkit_glue::FormField;
 
+namespace {
+
+// TODO(isherman): Pull this as a named constant from WebKit
+const int kDefaultMaxLength = 0x80000;
+
+}

[dhollowa, 2010/11/19 15:45:22]

nit: }  // namespace

+
 // Test that we get form state change notifications when input fields change.
 TEST_F(RenderViewTest, OnNavStateChanged) {
   // Don't want any delay for form state sync changes. This will still post a
   // message so updates will get coalesced, but as soon as we spin the message
   // loop, it will generate an update.
   view_->set_send_content_state_immediately(true);
 
   LoadHTML("<input type=\"text\" id=\"elt_text\"></input>");
 
   // We should NOT have gotten a form state change notification yet.
@@ skipping 884 matching lines @@
   ViewHostMsg_FormsSeen::Param params;
   ViewHostMsg_FormsSeen::Read(message, &params);
   const std::vector<FormData>& forms = params.a;
   ASSERT_EQ(1UL, forms.size());
   ASSERT_EQ(3UL, forms[0].fields.size());
   EXPECT_TRUE(forms[0].fields[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
                 string16(),
                 ASCIIToUTF16("text"),
-                20))) << forms[0].fields[0];
+                kDefaultMaxLength))) << forms[0].fields[0];
   EXPECT_TRUE(forms[0].fields[1].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("middlename"),
                 string16(),
                 ASCIIToUTF16("text"),
-                20))) << forms[0].fields[1];
+                kDefaultMaxLength))) << forms[0].fields[1];
   EXPECT_TRUE(forms[0].fields[2].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("lastname"),
                 string16(),
                 ASCIIToUTF16("hidden"),
                 0))) << forms[0].fields[2];
 
   // Verify that |didAcceptAutoFillSuggestion()| sends the expected number of
   // fields.
   WebFrame* web_frame = GetMainFrame();
@@ skipping 16 matching lines @@
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message2);
   ViewHostMsg_FillAutoFillFormData::Param params2;
   ViewHostMsg_FillAutoFillFormData::Read(message2, &params2);
   const FormData& form2 = params2.b;
   ASSERT_EQ(3UL, form2.fields.size());
   EXPECT_TRUE(form2.fields[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
                 string16(),
                 ASCIIToUTF16("text"),
-                20))) << form2.fields[0];
+                kDefaultMaxLength))) << form2.fields[0];
   EXPECT_TRUE(form2.fields[1].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("middlename"),
                 string16(),
                 ASCIIToUTF16("text"),
-                20))) << form2.fields[1];
+                kDefaultMaxLength))) << form2.fields[1];
   EXPECT_TRUE(form2.fields[2].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("lastname"),
                 string16(),
                 ASCIIToUTF16("hidden"),
                 0))) << form2.fields[2];
 }
 
 TEST_F(RenderViewTest, FillFormElement) {
   // Don't want any delay for form state sync changes. This will still post a
@@ skipping 14 matching lines @@
   ViewHostMsg_FormsSeen::Param params;
   ViewHostMsg_FormsSeen::Read(message, &params);
   const std::vector<FormData>& forms = params.a;
   ASSERT_EQ(1UL, forms.size());
   ASSERT_EQ(2UL, forms[0].fields.size());
   EXPECT_TRUE(forms[0].fields[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
                 string16(),
                 ASCIIToUTF16("text"),
-                20))) << forms[0].fields[0];
+                kDefaultMaxLength))) << forms[0].fields[0];
   EXPECT_TRUE(forms[0].fields[1].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("middlename"),
                 string16(),
                 ASCIIToUTF16("text"),
-                20))) << forms[0].fields[1];
+                kDefaultMaxLength))) << forms[0].fields[1];
 
   // Verify that |didAcceptAutoFillSuggestion()| sets the value of the expected
   // field.
   WebFrame* web_frame = GetMainFrame();
   WebDocument document = web_frame->document();
   WebInputElement firstname =
       document.getElementById("firstname").to<WebInputElement>();
   WebInputElement middlename =
       document.getElementById("middlename").to<WebInputElement>();
   middlename.setAutofilled(true);
@@ skipping 76 matching lines @@
   LoadHTML("<html><head><meta http-equiv=\"content-language\" "
            "content=\" fr , es,en \">"
            "</head><body>A random page with random content.</body></html>");
   ProcessPendingMessages();
   message = render_thread_.sink().GetUniqueMessageMatching(
       ViewHostMsg_PageContents::ID);
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message);
   ViewHostMsg_PageContents::Read(message, &params);
   EXPECT_EQ("fr", params.d);
 }