Autofill: Prefer maxLength to size attribute for form filling heuristics.

chrome/browser/autofill/autofill_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_manager.h"
 
 #include <limits>
 #include <string>
 
 #include "app/l10n_util.h"
@@ skipping 587 matching lines @@
 }
 
 void AutoFillManager::FillPhoneNumberField(const AutoFillProfile* profile,
                                            webkit_glue::FormField* field) {
   // If we are filling a phone number, check to see if the size field
   // matches the "prefix" or "suffix" sizes and fill accordingly.
   string16 number = profile->GetFieldText(AutoFillType(PHONE_HOME_NUMBER));
   bool has_valid_suffix_and_prefix = (number.length() ==
       (kAutoFillPhoneNumberPrefixCount + kAutoFillPhoneNumberSuffixCount));
   if (has_valid_suffix_and_prefix &&
-      field->size() == kAutoFillPhoneNumberPrefixCount) {
+      field->max_length() == kAutoFillPhoneNumberPrefixCount) {
     number = number.substr(kAutoFillPhoneNumberPrefixOffset,
                            kAutoFillPhoneNumberPrefixCount);
     field->set_value(number);
   } else if (has_valid_suffix_and_prefix &&
-             field->size() == kAutoFillPhoneNumberSuffixCount) {
+             field->max_length() == kAutoFillPhoneNumberSuffixCount) {
     number = number.substr(kAutoFillPhoneNumberSuffixOffset,
                            kAutoFillPhoneNumberSuffixCount);
     field->set_value(number);
   } else {
     field->set_value(number);
   }
 }
 
 void AutoFillManager::ParseForms(const std::vector<FormData>& forms) {
   std::vector<FormStructure *> non_queryable_forms;
@@ skipping 73 matching lines @@
     return std::string();
 
   std::map<int, std::string>::const_iterator iter = id_guid_map_.find(id);
   if (iter == id_guid_map_.end()) {
     NOTREACHED();
     return std::string();
   }
 
   return iter->second;
 }