[fsp] Add support for providing thumbnails.

chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom binding for the fileSystemProvider API.
 
 var binding = require('binding').Binding.create('fileSystemProvider');
 var fileSystemProviderInternal =
     require('binding').Binding.create('fileSystemProviderInternal').generate();
 var eventBindings = require('event_bindings');
@@ skipping 20 matching lines @@
  */
 function annotateMetadata(metadata) {
   var result = {
     isDirectory: metadata.isDirectory,
     name: metadata.name,
     size: metadata.size,
     modificationTime: annotateDate(metadata.modificationTime)
   };
   if ('mimeType' in metadata)
     result.mimeType = metadata.mimeType;
+  if ('thumbnail' in metadata)
+    result.thumbnail = metadata.thumbnail;
   return result;
 }
 
 /**
  * Massages arguments of an event raised by the File System Provider API.
  * @param {Array.<*>} args Input arguments.
  * @param {function(Array.<*>)} dispatch Closure to be called with massaged
  *     arguments.
  */
 function massageArgumentsDefault(args, dispatch) {
@@ skipping 83 matching lines @@
 eventBindings.registerArgumentMassager(
     'fileSystemProvider.onUnmountRequested',
     massageArgumentsDefault);
 
 eventBindings.registerArgumentMassager(
     'fileSystemProvider.onGetMetadataRequested',
     function(args, dispatch) {
       var executionStart = Date.now();
       var options = args[0];
       var onSuccessCallback = function(metadata) {
+        // It is invalid to return a thumbnail when it's not requested. The
+        // restriction is added in order to avoid fetching the thumbnail while
+        // it's not needed.
+        if (!options.thumbnail && metadata.thumbnail) {

[hirono, 2014/08/27 09:20:08]

How about checking format of thumbnail?
The string may not start with 'data:' and valid image types.

[mtomasz, 2014/08/28 04:57:55]

Good idea. If users passed something invalid (like http://... for urls allowed
by our csp) then it could affect security. Added here and a sanity check in
get_metadata.cc. Done.

+          fileSystemProviderInternal.operationRequestedError(
+              options.fileSystemId, options.requestId, 'FAILED',
+              Date.now() - executionStart);
+          throw new Error('Thumbnail data is provided, but not requested.');
+        }
+
         fileSystemProviderInternal.getMetadataRequestedSuccess(
             options.fileSystemId,
             options.requestId,
             annotateMetadata(metadata),
             Date.now() - executionStart);
       };
       var onErrorCallback = function(error) {
         fileSystemProviderInternal.operationRequestedError(
             options.fileSystemId, options.requestId, error,
             Date.now() - executionStart);
       }
       dispatch([options, onSuccessCallback, onErrorCallback]);
     });
 
 eventBindings.registerArgumentMassager(
     'fileSystemProvider.onReadDirectoryRequested',
     function(args, dispatch) {
       var executionStart = Date.now();
       var options = args[0];
       var onSuccessCallback = function(entries, hasNext) {
         var annotatedEntries = entries.map(annotateMetadata);
+        // It is invalid to return a thumbnail when it's not requested.
+        annotatedEntries.forEach(function(metadata) {
+          if (metadata.thumbnail) {
+            fileSystemProviderInternal.operationRequestedError(
+                options.fileSystemId, options.requestId, 'FAILED',
+                Date.now() - executionStart);
+            throw new Error(
+                'Thumbnails must not be provided when reading a directory.');
+          }
+        });
         fileSystemProviderInternal.readDirectoryRequestedSuccess(
             options.fileSystemId, options.requestId, annotatedEntries, hasNext,
             Date.now() - executionStart);
       };
       var onErrorCallback = function(error) {
         fileSystemProviderInternal.operationRequestedError(
             options.fileSystemId, options.requestId, error,
             Date.now() - executionStart);
       }
       dispatch([options, onSuccessCallback, onErrorCallback]);
@@ skipping 51 matching lines @@
 
 eventBindings.registerArgumentMassager(
     'fileSystemProvider.onWriteFileRequested',
     massageArgumentsDefault);
 
 eventBindings.registerArgumentMassager(
     'fileSystemProvider.onAbortRequested',
     massageArgumentsDefault);
 
 exports.binding = binding.generate();