Manual devtools fixups for scoped_refptr operator T* removal.

Manual devtools fixups for scoped_refptr operator T* removal.

BUG=110610
TBR=kaznacheev@chromium.org

Committed: https://crrev.com/bd7a5660c5361ef7119d9eb5795d759600f6cc04
Cr-Commit-Position: refs/heads/master@{#292363}

[dcheng, 2014-08-28 09:15:36]

dcheng@chromium.org changed reviewers:
+ yurys@chromium.org

[dcheng, 2014-08-28 09:15:36]

Please take a look--the tooling deliberately skipped instances where a temporary
scoped_refptr was turned into a raw pointer. As a result, I've changed several
methods to take a const scoped_refptr<T>& to make it clearer that the method in
question will end up taking a reference to the object.

[dgozman, 2014-08-28 09:31:21]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2014-08-28 09:31:21]

lgtm

https://codereview.chromium.org/513673004/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_ui_bindings.h (right):

https://codereview.chromium.org/513673004/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_ui_bindings.h:76: void AttachTo(const
scoped_refptr<content::DevToolsAgentHost>& agent_host);
There is a call to this method in chrome/browser/ui/webui/inspect_ui.cc. It will
now create a temporary scoped_refptr. Maybe fix right away?

[dcheng, 2014-08-28 09:45:22]

https://codereview.chromium.org/513673004/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_ui_bindings.h (right):

https://codereview.chromium.org/513673004/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_ui_bindings.h:76: void AttachTo(const
scoped_refptr<content::DevToolsAgentHost>& agent_host);
On 2014/08/28 09:31:21, dgozman wrote:
> There is a call to this method in chrome/browser/ui/webui/inspect_ui.cc. It
will
> now create a temporary scoped_refptr. Maybe fix right away?

Done. I'm going to run an automated tool over the codebase after operator T* is
removed to clean up other instances of this as well, but thanks for this catch.

[dcheng, 2014-08-28 09:46:21]

dcheng@chromium.org changed reviewers:
+ kaznacheev@chromium.org

[dcheng, 2014-08-28 09:46:21]

TBRing kaznacheev@ for inspect_ui.cc changes.

[dcheng, 2014-08-28 09:46:35]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-28 09:47:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/513673004/20001

[commit-bot: I haz the power, 2014-08-28 10:43:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 11:08:36]

Committed patchset #2 (id:20001) as f194fdb2da45b786620c93583d816588db86e688

[commit-bot: I haz the power, 2014-09-10 02:58:57]

Patchset 2 (id:??) landed as
https://crrev.com/bd7a5660c5361ef7119d9eb5795d759600f6cc04
Cr-Commit-Position: refs/heads/master@{#292363}