Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 513663002: Revert of Cleanup: Remove unneeded SSE2 checks and unused code. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup: Remove unneeded SSE2 checks and unused code. (patchset #4 of https://codereview.chromium.org/459603003/) Reason for revert: Passed the win x64 trybot, but failed on the win 64 builder. Original issue's description: > Cleanup: Remove unneeded SSE2 checks and unused code. > > BUG=349320 > > Committed: https://chromium.googlesource.com/chromium/src/+/b2cd99b39c3744f61231f8818f6c7a3d2881f0f0 TBR=cpu@chromium.org,dalecurtis@chromium.org,senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=349320 Committed: https://crrev.com/55234498566db7ff749af32df42eafce48d2837c Cr-Commit-Position: refs/heads/master@{#292101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -28 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/simd/convert_yuv_to_rgb.h View 4 chunks +35 lines, -0 lines 0 comments Download
A media/base/simd/convert_yuv_to_rgb_mmx.asm View 1 chunk +23 lines, -0 lines 0 comments Download
M media/base/simd/convert_yuv_to_rgb_x86.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M media/base/yuv_convert.cc View 1 chunk +29 lines, -20 lines 0 comments Download
M media/base/yuv_convert_perftest.cc View 3 chunks +79 lines, -0 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 3 chunks +99 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/convolver.h View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/convolver.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Cleanup: Remove unneeded SSE2 checks and unused code.
6 years, 3 months ago (2014-08-27 06:32:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/513663002/1
6 years, 3 months ago (2014-08-27 06:33:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 1b838f36c595a273c66156230637681cdc85e57e
6 years, 3 months ago (2014-08-27 06:34:26 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55234498566db7ff749af32df42eafce48d2837c
Cr-Commit-Position: refs/heads/master@{#292101}

Powered by Google App Engine
This is Rietveld 408576698