Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 513633002: Reland 596ff54335b2a1b393af10657bc4945114f3beed - Split API bundle generation steps (Closed)

Created:
6 years, 3 months ago by Yoyo Zhou
Modified:
6 years, 3 months ago
Reviewers:
sky, scottmg
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Reland 596ff54335b2a1b393af10657bc4945114f3beed - Split API bundle generation steps * Fixed in this version: dependencies for *_api_registration on *_api. Split bundle generation steps so that API registration is generated in browser, not common. We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common. Fix a couple of dangling gyp issues also. BUG=405226 TBR=scottmg@chromium.org,sky@chromium.org Committed: https://crrev.com/774dcda2d369584b2e964fa4971dda71cf819677 Cr-Commit-Position: refs/heads/master@{#292090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -533 lines) Patch
M build/json_schema_bundle_compile.gypi View 2 chunks +20 lines, -20 lines 0 comments Download
A + build/json_schema_bundle_registration_compile.gypi View 3 chunks +28 lines, -26 lines 0 comments Download
M build/json_schema_compile.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/api_registration.gyp View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/performance_monitor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 chunk +12 lines, -32 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 2 chunks +1 line, -210 lines 0 comments Download
A chrome/common/extensions/api/schemas.gni View 1 chunk +34 lines, -0 lines 0 comments Download
A + chrome/common/extensions/api/schemas.gypi View 2 chunks +43 lines, -81 lines 0 comments Download
M content/app/content_main_runner.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A extensions/browser/api/api_registration.gyp View 1 chunk +30 lines, -0 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +9 lines, -21 lines 0 comments Download
M extensions/common/api/api.gyp View 1 chunk +1 line, -48 lines 0 comments Download
A extensions/common/api/schemas.gni View 1 chunk +17 lines, -0 lines 0 comments Download
A extensions/common/api/schemas.gypi View 1 chunk +51 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/generated_extensions_api.gni View 6 chunks +88 lines, -44 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/api_registration.gyp View 1 chunk +22 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/common/api/api.gyp View 1 chunk +1 line, -18 lines 0 comments Download
A extensions/shell/common/api/schemas.gypi View 1 chunk +20 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/compiler.py View 6 chunks +25 lines, -14 lines 0 comments Download
M tools/json_schema_compiler/cpp_bundle_generator.py View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
TBR: scottmg, sky for reland (The patch was reverted because I missed a subtle dependency ...
6 years, 3 months ago (2014-08-27 02:05:16 UTC) #1
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 3 months ago (2014-08-27 02:05:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/513633002/1
6 years, 3 months ago (2014-08-27 02:06:44 UTC) #3
scottmg
6 years, 3 months ago (2014-08-27 02:47:59 UTC) #4
scottmg
On 2014/08/27 02:47:59, scottmg wrote: (Hmm, 2 reply dialogs appears to have broken in rietveld..) ...
6 years, 3 months ago (2014-08-27 02:49:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 52711b45ace5d4a66684eef970abac17d3aa3903
6 years, 3 months ago (2014-08-27 03:33:13 UTC) #6
Yoyo Zhou
On 2014/08/27 02:49:45, scottmg wrote: > On 2014/08/27 02:47:59, scottmg wrote: > > (Hmm, 2 ...
6 years, 3 months ago (2014-08-27 19:44:16 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/774dcda2d369584b2e964fa4971dda71cf819677
Cr-Commit-Position: refs/heads/master@{#292090}

Powered by Google App Engine
This is Rietveld 408576698