Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: chrome/chrome_tests_unit.gypi

Issue 513623002: Cleanup: Combine some identical conditionals in chrome gyp targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'targets': [ 5 'targets': [
6 { 6 {
7 # This target contains mocks and test utilities that don't belong in 7 # This target contains mocks and test utilities that don't belong in
8 # production libraries but are used by more than one test executable. 8 # production libraries but are used by more than one test executable.
9 'target_name': 'test_support_common', 9 'target_name': 'test_support_common',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 2165 matching lines...) Expand 10 before | Expand all | Expand 10 after
2176 # be fixed by creating a separate unit test target, or by deleting 2176 # be fixed by creating a separate unit test target, or by deleting
2177 # the test. 2177 # the test.
2178 'browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2_unittest.cc ' 2178 'browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2_unittest.cc '
2179 ], 2179 ],
2180 }], 2180 }],
2181 ['enable_task_manager==0', { 2181 ['enable_task_manager==0', {
2182 'sources/': [ 2182 'sources/': [
2183 ['exclude', '^browser/task_manager/'], 2183 ['exclude', '^browser/task_manager/'],
2184 ], 2184 ],
2185 }], 2185 }],
2186 ['chromeos==0', {
2187 'sources!': [
2188 # TODO(zturner): Enable this on Windows. See
2189 # BrowserWithTestWindowTest::SetUp() for a comment explaining why
2190 # this is broken.
2191 'browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc',
2192 'browser/ui/views/select_file_dialog_extension_unittest.cc',
2193 ],
2194 }],
2195 ['enable_mdns==1', { 2186 ['enable_mdns==1', {
2196 'sources': [ 2187 'sources': [
2197 'browser/local_discovery/privet_device_lister_unittest.cc', 2188 'browser/local_discovery/privet_device_lister_unittest.cc',
2198 'browser/local_discovery/privet_local_printer_lister_unittest.cc', 2189 'browser/local_discovery/privet_local_printer_lister_unittest.cc',
2199 'browser/local_discovery/privet_notifications_unittest.cc', 2190 'browser/local_discovery/privet_notifications_unittest.cc',
2200 'common/local_discovery/local_domain_resolver_unittest.cc', 2191 'common/local_discovery/local_domain_resolver_unittest.cc',
2201 'common/local_discovery/service_discovery_client_unittest.cc', 2192 'common/local_discovery/service_discovery_client_unittest.cc',
2202 ], 2193 ],
2203 }], 2194 }],
2204 ['enable_service_discovery==1', { 2195 ['enable_service_discovery==1', {
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
2276 'sources!': [ 2267 'sources!': [
2277 'browser/component_updater/test/component_installers_unittest.cc', 2268 'browser/component_updater/test/component_installers_unittest.cc',
2278 'browser/metrics/plugin_metrics_provider_unittest.cc', 2269 'browser/metrics/plugin_metrics_provider_unittest.cc',
2279 'common/pepper_permission_util_unittest.cc', 2270 'common/pepper_permission_util_unittest.cc',
2280 ], 2271 ],
2281 }], 2272 }],
2282 ['enable_printing!=1', { 2273 ['enable_printing!=1', {
2283 'sources/': [ 2274 'sources/': [
2284 ['exclude', '^browser/printing/'], 2275 ['exclude', '^browser/printing/'],
2285 ['exclude', '^browser/ui/webui/print_preview/'], 2276 ['exclude', '^browser/ui/webui/print_preview/'],
2277 # No need for service process.
2278 ['exclude', '^browser/service/'],
2279 ['exclude', '^common/service_'],
2286 ['exclude', '^service/'], 2280 ['exclude', '^service/'],
2287 ], 2281 ],
2288 'sources!': [ 2282 'sources!': [
2289 'browser/local_discovery/privet_http_unittest.cc', 2283 'browser/local_discovery/privet_http_unittest.cc',
2290 ], 2284 ],
2291 }], 2285 }],
2292 ['enable_captive_portal_detection!=1', { 2286 ['enable_captive_portal_detection!=1', {
2293 'sources/': [ 2287 'sources/': [
2294 ['exclude', '^browser/captive_portal/'], 2288 ['exclude', '^browser/captive_portal/'],
2295 ], 2289 ],
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
2344 'sources/': [ 2338 'sources/': [
2345 ['exclude', '^browser/chromeos/'], 2339 ['exclude', '^browser/chromeos/'],
2346 ['exclude', '^browser/ui/webui/chromeos/imageburner/'], 2340 ['exclude', '^browser/ui/webui/chromeos/imageburner/'],
2347 ['exclude', '^browser/ui/webui/chromeos/login'], 2341 ['exclude', '^browser/ui/webui/chromeos/login'],
2348 ['exclude', '^browser/ui/webui/options/chromeos/'], 2342 ['exclude', '^browser/ui/webui/options/chromeos/'],
2349 ['exclude', '^browser/ui/webui/options/chromeos/'], 2343 ['exclude', '^browser/ui/webui/options/chromeos/'],
2350 ['exclude', '^browser/resources/chromeos/'], 2344 ['exclude', '^browser/resources/chromeos/'],
2351 ], 2345 ],
2352 'sources!': [ 2346 'sources!': [
2353 'browser/extensions/api/enterprise_platform_keys_private/enterprise_ platform_keys_private_api_unittest.cc', 2347 'browser/extensions/api/enterprise_platform_keys_private/enterprise_ platform_keys_private_api_unittest.cc',
2348 'browser/extensions/api/log_private/syslog_parser_unittest.cc',
2354 'browser/notifications/login_state_notification_blocker_chromeos_uni ttest.cc', 2349 'browser/notifications/login_state_notification_blocker_chromeos_uni ttest.cc',
2355 'browser/extensions/api/log_private/syslog_parser_unittest.cc', 2350 # TODO(zturner): Enable this on Windows. See
2351 # BrowserWithTestWindowTest::SetUp() for a comment explaining why
2352 # this is broken.
2353 'browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc',
2354 'browser/ui/views/select_file_dialog_extension_unittest.cc',
2356 ], 2355 ],
2357 }], 2356 }],
2358 ['use_x11==1', { 2357 ['use_x11==1', {
2359 'dependencies': [ 2358 'dependencies': [
2360 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', 2359 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
2361 ], 2360 ],
2362 }], 2361 }],
2363 ['OS=="linux"', { 2362 ['OS=="linux"', {
2364 'dependencies': [ 2363 'dependencies': [
2365 '../build/linux/system.gyp:ssl', 2364 '../build/linux/system.gyp:ssl',
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
2402 ], 2401 ],
2403 }], 2402 }],
2404 ['OS=="mac"', { 2403 ['OS=="mac"', {
2405 # The test fetches resources which means Mac need the app bundle to 2404 # The test fetches resources which means Mac need the app bundle to
2406 # exist on disk so it can pull from it. 2405 # exist on disk so it can pull from it.
2407 'dependencies': [ 2406 'dependencies': [
2408 '../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:go ogle_toolbox_for_mac', 2407 '../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:go ogle_toolbox_for_mac',
2409 '../third_party/ocmock/ocmock.gyp:ocmock', 2408 '../third_party/ocmock/ocmock.gyp:ocmock',
2410 'chrome', 2409 'chrome',
2411 ], 2410 ],
2411 'sources': [
2412 'browser/media_galleries/fileapi/iphoto_file_util_unittest.cc',
2413 'utility/media_galleries/iphoto_library_parser_unittest.cc',
2414 ],
2412 'sources!': [ 2415 'sources!': [
2413 'browser/ui/tests/ui_gfx_image_unittest.cc', 2416 'browser/ui/tests/ui_gfx_image_unittest.cc',
2414 'tools/convert_dict/convert_dict_unittest.cc', 2417 'tools/convert_dict/convert_dict_unittest.cc',
2415 'renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc', 2418 'renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc',
2416 ], 2419 ],
2417 # TODO(mark): We really want this for all non-static library targets, 2420 # TODO(mark): We really want this for all non-static library targets,
2418 # but when we tried to pull it up to the common.gypi level, it broke 2421 # but when we tried to pull it up to the common.gypi level, it broke
2419 # other things like the ui and startup tests. *shrug* 2422 # other things like the ui and startup tests. *shrug*
2420 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']}, 2423 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
2421 }], 2424 }],
(...skipping 14 matching lines...) Expand all
2436 'sources': [ 2439 'sources': [
2437 'browser/media_galleries/fileapi/itunes_file_util_unittest.cc', 2440 'browser/media_galleries/fileapi/itunes_file_util_unittest.cc',
2438 'browser/media_galleries/fileapi/picasa_file_util_unittest.cc', 2441 'browser/media_galleries/fileapi/picasa_file_util_unittest.cc',
2439 'common/extensions/api/networking_private/networking_private_crypto_ unittest.cc', 2442 'common/extensions/api/networking_private/networking_private_crypto_ unittest.cc',
2440 'utility/media_galleries/itunes_library_parser_unittest.cc', 2443 'utility/media_galleries/itunes_library_parser_unittest.cc',
2441 'utility/media_galleries/picasa_album_table_reader_unittest.cc', 2444 'utility/media_galleries/picasa_album_table_reader_unittest.cc',
2442 'utility/media_galleries/picasa_albums_indexer_unittest.cc', 2445 'utility/media_galleries/picasa_albums_indexer_unittest.cc',
2443 'utility/media_galleries/pmp_column_reader_unittest.cc', 2446 'utility/media_galleries/pmp_column_reader_unittest.cc',
2444 ], 2447 ],
2445 }], 2448 }],
2446 ['OS=="mac"', {
2447 'sources': [
2448 'browser/media_galleries/fileapi/iphoto_file_util_unittest.cc',
2449 'utility/media_galleries/iphoto_library_parser_unittest.cc',
2450 ],
2451 }],
2452 ['enable_rlz!=0', { 2449 ['enable_rlz!=0', {
2453 'dependencies': [ 2450 'dependencies': [
2454 '../rlz/rlz.gyp:test_support_rlz', 2451 '../rlz/rlz.gyp:test_support_rlz',
2455 ], 2452 ],
2456 }, { # enable_rlz==0 2453 }, { # enable_rlz==0
2457 'sources!': [ 2454 'sources!': [
2458 'browser/rlz/rlz_unittest.cc', 2455 'browser/rlz/rlz_unittest.cc',
2459 ], 2456 ],
2460 }], 2457 }],
2461 ['OS=="win" and component!="shared_library"', { 2458 ['OS=="win" and component!="shared_library"', {
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
2629 # Android doesn't support download feedbacks. 2626 # Android doesn't support download feedbacks.
2630 'browser/safe_browsing/download_feedback_unittest.cc', 2627 'browser/safe_browsing/download_feedback_unittest.cc',
2631 'browser/safe_browsing/download_feedback_service_unittest.cc', 2628 'browser/safe_browsing/download_feedback_service_unittest.cc',
2632 'browser/safe_browsing/download_protection_service_unittest.cc', 2629 'browser/safe_browsing/download_protection_service_unittest.cc',
2633 'browser/safe_browsing/two_phase_uploader_unittest.cc', 2630 'browser/safe_browsing/two_phase_uploader_unittest.cc',
2634 ], 2631 ],
2635 'sources/': [ 2632 'sources/': [
2636 ['exclude', '^browser/captive_portal/'], 2633 ['exclude', '^browser/captive_portal/'],
2637 ['exclude', '^browser/diagnostics/'], 2634 ['exclude', '^browser/diagnostics/'],
2638 ['exclude', '^browser/first_run/'], 2635 ['exclude', '^browser/first_run/'],
2636 ['exclude', '^browser/importer/'],
2639 ['exclude', '^browser/lifetime/'], 2637 ['exclude', '^browser/lifetime/'],
2640 ['exclude', '^browser/media_galleries/'], 2638 ['exclude', '^browser/media_galleries/'],
2641 ['exclude', '^browser/net/firefox_*'], 2639 ['exclude', '^browser/net/firefox_*'],
2642 ['exclude', '^browser/profile_resetter/'], 2640 ['exclude', '^browser/profile_resetter/'],
2643 ['exclude', '^browser/speech/'], 2641 ['exclude', '^browser/speech/'],
2644 ['exclude', '^browser/sync/glue/app_'], 2642 ['exclude', '^browser/sync/glue/app_'],
2645 ['exclude', '^browser/sync/glue/extension_'], 2643 ['exclude', '^browser/sync/glue/extension_'],
2646 ['exclude', '^browser/themes/'], 2644 ['exclude', '^browser/themes/'],
2647 ['exclude', '^browser/ui/autofill/.*credit_card_bubble.*'], 2645 ['exclude', '^browser/ui/autofill/.*credit_card_bubble.*'],
2648 ['exclude', '^browser/ui/content_settings/'], 2646 ['exclude', '^browser/ui/content_settings/'],
(...skipping 22 matching lines...) Expand all
2671 ['OS!="android" and OS!="ios" and chromeos==0 and configuration_policy== 1', { 2669 ['OS!="android" and OS!="ios" and chromeos==0 and configuration_policy== 1', {
2672 'sources': [ 2670 'sources': [
2673 'browser/net/disk_cache_dir_policy_handler_unittest.cc', 2671 'browser/net/disk_cache_dir_policy_handler_unittest.cc',
2674 ], 2672 ],
2675 }], 2673 }],
2676 ['OS!="android" and OS!="ios" and configuration_policy==1', { 2674 ['OS!="android" and OS!="ios" and configuration_policy==1', {
2677 'sources': [ 2675 'sources': [
2678 'browser/download/download_dir_policy_handler_unittest.cc' 2676 'browser/download/download_dir_policy_handler_unittest.cc'
2679 ], 2677 ],
2680 }], 2678 }],
2681 ['enable_printing!=1', {
2682 'sources/': [
2683 # No need for service process.
2684 ['exclude', '^browser/service/'],
2685 ['exclude', '^common/service_'],
2686 ['exclude', '^service/'],
2687 ],
2688 }],
2689 ['enable_themes==0', { 2679 ['enable_themes==0', {
2690 'sources!': [ 2680 'sources!': [
2691 'browser/ui/webui/theme_source_unittest.cc', 2681 'browser/ui/webui/theme_source_unittest.cc',
2692 ], 2682 ],
2693 'sources/': [ 2683 'sources/': [
2694 ['exclude', '^browser/themes/'], 2684 ['exclude', '^browser/themes/'],
2695 ], 2685 ],
2696 }], 2686 }],
2697 ['toolkit_views==1', { 2687 ['toolkit_views==1', {
2698 'dependencies': [ 2688 'dependencies': [
2699 '../components/components.gyp:web_modal_test_support', 2689 '../components/components.gyp:web_modal_test_support',
2700 '../ui/views/views.gyp:views', 2690 '../ui/views/views.gyp:views',
2701 '../ui/views/views.gyp:views_test_support', 2691 '../ui/views/views.gyp:views_test_support',
2702 ], 2692 ],
2703 }, { # else: toolkit_views == 0 2693 }, { # else: toolkit_views == 0
2704 'sources/': [ 2694 'sources/': [
2705 ['exclude', '^browser/ui/views/'], 2695 ['exclude', '^browser/ui/views/'],
2706 ['exclude', '^../apps/ui/views/'], 2696 ['exclude', '^../apps/ui/views/'],
2707 ['exclude', '^../ui/views/'], 2697 ['exclude', '^../ui/views/'],
2708 ], 2698 ],
2709 }], 2699 }],
2710 ['use_nss==0 and use_openssl_certs==0', { 2700 ['use_nss==0 and use_openssl_certs==0', {
2711 'sources!': [ 2701 'sources!': [
2712 'common/net/x509_certificate_model_unittest.cc', 2702 'common/net/x509_certificate_model_unittest.cc',
2713 ], 2703 ],
2714 }], 2704 }],
2715 ['OS=="android"', {
2716 'sources/': [
2717 # Android doesn't build the importer.
2718 ['exclude', '^browser/importer/'],
2719 ],
2720 }],
2721 ['enable_managed_users!=1', { 2705 ['enable_managed_users!=1', {
2722 'sources/': [ 2706 'sources/': [
2723 ['exclude', '^browser/supervised_user/'], 2707 ['exclude', '^browser/supervised_user/'],
2724 ], 2708 ],
2725 }], 2709 }],
2726 ['safe_browsing==1 and enable_extensions==1', { 2710 ['safe_browsing==1 and enable_extensions==1', {
2727 'sources': [ 2711 'sources': [
2728 'browser/extensions/blacklist_unittest.cc', 2712 'browser/extensions/blacklist_unittest.cc',
2729 ], 2713 ],
2730 }], 2714 }],
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
2887 'dependencies': [ 2871 'dependencies': [
2888 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', 2872 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
2889 ], 2873 ],
2890 }], 2874 }],
2891 ], 2875 ],
2892 }, 2876 },
2893 ], 2877 ],
2894 }], 2878 }],
2895 ], # 'conditions' 2879 ], # 'conditions'
2896 } 2880 }
OLDNEW
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698