|
|
DescriptionCommitted: https://crrev.com/681cc8e61e5142f490a176e57dba0f2d2a44d14c
Cr-Commit-Position: refs/heads/master@{#292217}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase #Messages
Total messages: 36 (0 generated)
marpan@google.com changed reviewers: + fgalligan@chromium.org, johannkoenig@google.com
On 2014/08/27 00:41:28, marpan wrote: lgtm
The CQ bit was checked by marpan@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marpan@google.com/513593002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by marpan@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marpan@google.com/513593002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by marpan@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marpan@google.com/513593002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by marpan@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marpan@google.com/513593002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47087) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52446) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by marpan@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marpan@google.com/513593002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52463)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52489)
On 2014/08/27 19:30:22, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > win_gpu on tryserver.chromium.gpu > (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52489) *sigh* I'm pretty sure you're losing a race-- DEPS is changing(again) before that bot actually updates, and then you see the patch fail because when it finally gets around to updating DEPS, DEPS has changed and the patch won't apply cleanly. Rebase and 'git cl land' it-- if a sheriff gives you trouble, point them here so we can be educated on how this is currently supposed to be handled since it seems TOTALLY IMPOSSIBLE to land a DEPS change without a bot hating us.
On 2014/08/27 19:53:01, Tom Finegan wrote: > On 2014/08/27 19:30:22, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > win_gpu on tryserver.chromium.gpu > > > (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52489) > > *sigh* > > I'm pretty sure you're losing a race-- DEPS is changing(again) before that bot > actually updates, and then you see the patch fail because when it finally gets > around to updating DEPS, DEPS has changed and the patch won't apply cleanly. > > Rebase and 'git cl land' it-- if a sheriff gives you trouble, point them here so > we can be educated on how this is currently supposed to be handled since it > seems TOTALLY IMPOSSIBLE to land a DEPS change without a bot hating us. Via the CQ, that is.
The CQ bit was checked by marpan@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marpan@google.com/513593002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) to pending queue manually as b150c15 (presubmit successful).
Message was sent while issue was closed.
On 2014/08/27 20:57:48, Tom Finegan wrote: > Committed patchset #4 (id:60001) to pending queue manually as b150c15 (presubmit > successful). @sheriffs If this needs a revert, first, my bad. Second: *sigh* I'm pretty sure you're losing a race-- DEPS is changing(again) before that bot actually updates, and then you see the patch fail because when it finally gets around to updating DEPS, DEPS has changed and the patch won't apply cleanly. Rebase and 'git cl land' it-- if a sheriff gives you trouble, point them here so we can be educated on how this is currently supposed to be handled since it seems TOTALLY IMPOSSIBLE to land a DEPS change via the CQ without a bot hating us.
Message was sent while issue was closed.
On 2014/08/27 20:59:05, Tom Finegan wrote: > On 2014/08/27 20:57:48, Tom Finegan wrote: > > Committed patchset #4 (id:60001) to pending queue manually as b150c15 > (presubmit > > successful). > > @sheriffs > > If this needs a revert, first, my bad. Second: > > *sigh* > > I'm pretty sure you're losing a race-- DEPS is changing(again) before that bot > actually updates, and then you see the patch fail because when it finally gets > around to updating DEPS, DEPS has changed and the patch won't apply cleanly. > > Rebase and 'git cl land' it-- if a sheriff gives you trouble, point them here so > we can be educated on how this is currently supposed to be handled since it > seems TOTALLY IMPOSSIBLE to land a DEPS change via the CQ without a bot hating > us. And to clarify, the "you're" was directed @marpan. This is from an earlier comment, and I've reposted it for visibility.
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/681cc8e61e5142f490a176e57dba0f2d2a44d14c Cr-Commit-Position: refs/heads/master@{#292217} |