Issue 513583002: closed. NOT FOR COMMIT Fix findbugs warning for TestWebServer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 513583002: closed. NOT FOR COMMIT Fix findbugs warning for TestWebServer (Closed)

Created:
6 years, 3 months ago by hush (inactive)

Modified:
6 years, 3 months ago

Reviewers:
Yaron

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix findbugs warning. BUG=

Patch Set 1 #

Patch Set 2 : separate the previus issue #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hush (inactive)

find bugs fails with this warning ******************************************************************************** New warnings. Please fix, or perhaps add to ...

6 years, 3 months ago (2014-08-27 00:25:39 UTC) #1

hush (inactive)

the original cl is reverted by https://codereview.chromium.org/514443002

6 years, 3 months ago (2014-08-27 00:27:51 UTC) #2

hush (inactive)

hush@chromium.org changed reviewers: + yfriedman@chromium.org

6 years, 3 months ago (2014-08-27 00:31:24 UTC) #3

hush (inactive)

6 years, 3 months ago (2014-08-27 01:24:43 UTC) #5

On 2014/08/27 00:31:59, hush wrote:
> PTAL

The revert of the revert is here:
https://codereview.chromium.org/512573002/

Expand Messages | Collapse Messages