Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: mojo/services/public/interfaces/content_handler/content_handler.mojom

Issue 513573002: Mojo: Fix two bugs in content handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Darin comments, updates for Android toolchain Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/content_handler/content_handler.mojom
diff --git a/mojo/services/public/interfaces/content_handler/content_handler.mojom b/mojo/services/public/interfaces/content_handler/content_handler.mojom
index 1a0ce072f074f5658a95b14e1b69d02127226816..134827909a11b796fe8fd04f2b289827c64c199e 100644
--- a/mojo/services/public/interfaces/content_handler/content_handler.mojom
+++ b/mojo/services/public/interfaces/content_handler/content_handler.mojom
@@ -7,10 +7,15 @@ import "mojo/services/public/interfaces/network/url_loader.mojom"
module mojo {
darin (slow to review) 2014/08/27 06:34:19 ContentSource perhaps? My motivation for thinking
Aaron Boodman 2014/08/27 18:26:13 I like ContentSource, thanks. Changed.
+struct ContentHandlerResponse {
+ URLLoader loader;
+ URLResponse response;
+};
+
interface ContentHandler {
- OnConnect(string? url,
- URLResponse? url_response,
- ServiceProvider? service_provider);
+ OnConnect(string url,
+ ContentHandlerResponse url_response,
+ ServiceProvider&? service_provider);
};
}

Powered by Google App Engine
This is Rietveld 408576698