Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: mojo/application_manager/application_manager.cc

Issue 513573002: Mojo: Fix two bugs in content handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application_manager/application_manager.cc
diff --git a/mojo/application_manager/application_manager.cc b/mojo/application_manager/application_manager.cc
index 3281681c4d354bd087ba95b8bf945e47df3aaa99..b0a300eb4b6c1b17e237dfc5f77a4129242e4b30 100644
--- a/mojo/application_manager/application_manager.cc
+++ b/mojo/application_manager/application_manager.cc
@@ -66,12 +66,12 @@ class ApplicationManager::LoadCallbacksImpl
}
virtual void LoadWithContentHandler(const GURL& content_handler_url,
- URLResponsePtr content) OVERRIDE {
+ URLResponsePtr url_response) OVERRIDE {
if (manager_) {
manager_->LoadWithContentHandler(requested_url_,
requestor_url_,
content_handler_url,
- content.Pass(),
+ url_response.Pass(),
service_provider_.Pass());
}
}
@@ -232,7 +232,7 @@ void ApplicationManager::LoadWithContentHandler(
const GURL& content_url,
const GURL& requestor_url,
const GURL& content_handler_url,
- URLResponsePtr content,
+ URLResponsePtr url_response,
ServiceProviderPtr service_provider) {
ContentHandlerConnection* connection = NULL;
URLToContentHandlerMap::iterator iter =
@@ -243,8 +243,11 @@ void ApplicationManager::LoadWithContentHandler(
connection = new ContentHandlerConnection(this, content_handler_url);
url_to_content_handler_[content_handler_url] = connection;
}
+
+ InterfaceRequest<ServiceProvider> spir;
+ spir.Bind(service_provider.PassMessagePipe());
connection->content_handler->OnConnect(
- content_url.spec(), content.Pass(), service_provider.Pass());
+ content_url.spec(), url_response.Pass(), spir.Pass());
}
void ApplicationManager::SetLoaderForURL(scoped_ptr<ApplicationLoader> loader,
« no previous file with comments | « mojo/application_manager/application_manager.h ('k') | mojo/examples/content_handler_demo/content_handler_demo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698