Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 513543004: [Sync] Rename FailedDataTypesHandler -> DataTypeStatusTable (Closed)

Created:
6 years, 3 months ago by Nicolas Zea
Modified:
6 years, 3 months ago
Reviewers:
haitaol1
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename FailedDataTypesHandler -> DataTypeStatusTable Simple rename patch, in preparation for making the DataTypeStatusTable copy-able and having it track more than just errors. BUG=368834 Committed: https://crrev.com/f9897b672e260fc23f50b6f35dab786450bd852d Cr-Commit-Position: refs/heads/master@{#292453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -366 lines) Patch
M chrome/browser/sync/profile_sync_components_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_mock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 10 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/data_type_manager_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/data_type_manager_impl.cc View 12 chunks +26 lines, -26 lines 0 comments Download
M components/sync_driver/data_type_manager_impl_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
A + components/sync_driver/data_type_status_table.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + components/sync_driver/data_type_status_table.cc View 8 chunks +20 lines, -20 lines 0 comments Download
D components/sync_driver/failed_data_types_handler.h View 1 chunk +0 lines, -99 lines 0 comments Download
D components/sync_driver/failed_data_types_handler.cc View 1 chunk +0 lines, -157 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nicolas Zea
zea@chromium.org changed reviewers: + haitaol@chromium.org
6 years, 3 months ago (2014-08-27 17:50:33 UTC) #1
Nicolas Zea
PTAL
6 years, 3 months ago (2014-08-27 17:50:33 UTC) #2
haitaol1
lgtm
6 years, 3 months ago (2014-08-28 16:58:25 UTC) #3
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 3 months ago (2014-08-28 18:00:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/513543004/1
6 years, 3 months ago (2014-08-28 18:02:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 19:27:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:23:04 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:23:05 UTC) #8
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 3 months ago (2014-08-28 20:36:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/513543004/1
6 years, 3 months ago (2014-08-28 20:38:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4fed8b72b78c17b34e324ee12e764372b586cb2f
6 years, 3 months ago (2014-08-28 20:39:19 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:55 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f9897b672e260fc23f50b6f35dab786450bd852d
Cr-Commit-Position: refs/heads/master@{#292453}

Powered by Google App Engine
This is Rietveld 408576698