Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 513533003: X87: Move register conventions out of the IC classes. (Closed)

Created:
6 years, 3 months ago by chunyang.dai
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Move register conventions out of the IC classes. port r23391. original commit message: Move register conventions out of the IC classes. A change to a convention shouldn't require recompilation of ic.h/.cc. BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -173 lines) Patch
M src/ic/x87/access-compiler-x87.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 2 chunks +7 lines, -6 lines 0 comments Download
A + src/ic/x87/ic-conventions-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 14 chunks +35 lines, -59 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/debug-x87.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 24 chunks +55 lines, -53 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M src/x87/lithium-x87.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
chunyang.dai
chunyang.dai@intel.com changed reviewers: + mvstanton@chromium.org, weiliang.lin@intel.com
6 years, 3 months ago (2014-08-27 03:47:19 UTC) #1
chunyang.dai
weiliang. please review it. thanks
6 years, 3 months ago (2014-08-27 03:47:39 UTC) #2
Weiliang
https://codereview.chromium.org/513533003/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/513533003/diff/1/tools/gyp/v8.gyp#newcode932 tools/gyp/v8.gyp:932: '../../src/ic/ia32/ic-conventions-x87.cc', Typo Should be x87 here
6 years, 3 months ago (2014-08-27 04:34:00 UTC) #3
chunyang.dai
fixed. thanks.
6 years, 3 months ago (2014-08-27 04:43:13 UTC) #4
Weiliang
lgtm
6 years, 3 months ago (2014-08-27 04:47:26 UTC) #5
Weiliang
6 years, 3 months ago (2014-08-27 04:56:48 UTC) #6 
Committed as r23428

Powered by Google App Engine
This is Rietveld 408576698