Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Issue 51353002: rebaseline_server: report proper URL upon launch (Closed)

Created:
7 years, 1 month ago by epoger
Modified:
7 years, 1 month ago
Reviewers:
jcgregorio
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

rebaseline_server: report proper URL upon launch BUG=skia:1767 (SkipBuildbotRuns) R=jcgregorio@google.com Committed: https://code.google.com/p/skia/source/detail?r=12016

Patch Set 1 #

Patch Set 2 : patch2 #

Total comments: 3

Patch Set 3 : close_socket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
gm/rebaseline_server/server.py View 1 2 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 2. https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py#newcode186 gm/rebaseline_server/server.py:186: logging.info('Ready for requests ...
7 years, 1 month ago (2013-10-29 20:25:28 UTC) #1
jcgregorio
https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py#newcode74 gm/rebaseline_server/server.py:74: sock.connect(('8.8.8.8', 80)) Should sock be closed()?
7 years, 1 month ago (2013-10-29 20:30:49 UTC) #2
epoger
https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py#newcode74 gm/rebaseline_server/server.py:74: sock.connect(('8.8.8.8', 80)) On 2013/10/29 20:30:49, jcgregorio wrote: > Should ...
7 years, 1 month ago (2013-10-29 20:35:04 UTC) #3
jcgregorio
On 2013/10/29 20:35:04, epoger wrote: > https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py > File gm/rebaseline_server/server.py (right): > > https://codereview.chromium.org/51353002/diff/30001/gm/rebaseline_server/server.py#newcode74 > ...
7 years, 1 month ago (2013-10-29 20:36:59 UTC) #4
epoger
7 years, 1 month ago (2013-10-30 14:09:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r12016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698