Clean up setting accessibility focus.

Clean up setting accessibility focus.

Consolidate the code to set accessibility focus to one place.
Fix it so we never set accessibility focus to the same id twice in a row,
as that puts things in a weird state (because we then get a "clear"
accessibility focus action on the current focused view).

In a couple of places where we want to explicitly update the focus,
set focus away and then back again so Android can't ignore it.

BUG=407871
Committed: https://crrev.com/c1ae0872e4c0336406ad47f6ab332174c3da80d5
Cr-Commit-Position: refs/heads/master@{#292386}

[dmazzoni, 2014-08-26 23:07:23]

dmazzoni@chromium.org changed reviewers:
+ plundblad@chromium.org

[Peter Lundblad, 2014-08-27 09:10:58]

lgtm

Good call!  I think our focus handling when the frame is not initialized is
still
a bit confusing, but I don't have a good suggestion for how to improve it
without introducing other confusion.

https://codereview.chromium.org/513483002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/513483002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:169:
}
The above block is half redundant. You could improve readability by making
moveAccessibilityFocusToId return a boolean whether it actually moved focus or
not and then use that return value here.

https://codereview.chromium.org/513483002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:294:
if (newAccessibilityFocusId == mAccessibilityFocusId &&
Can you add a comment explaining why we are doing this?

[dmazzoni, 2014-08-27 18:32:06]

https://codereview.chromium.org/513483002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/513483002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:169:
}
On 2014/08/27 09:10:58, Peter Lundblad wrote:
> The above block is half redundant. You could improve readability by making
> moveAccessibilityFocusToId return a boolean whether it actually moved focus or
> not and then use that return value here.

Good idea, done.

https://codereview.chromium.org/513483002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:294:
if (newAccessibilityFocusId == mAccessibilityFocusId &&
On 2014/08/27 09:10:58, Peter Lundblad wrote:
> Can you add a comment explaining why we are doing this?

Done.

[dmazzoni, 2014-08-27 19:27:12]

https://codereview.chromium.org/513483002/diff/60001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/513483002/diff/60001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:297:
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
I changed this to a focus clear, as suggested in the subsequent change:

https://codereview.chromium.org/505423002/diff/20001/content/public/android/j...

[dmazzoni, 2014-08-27 19:27:15]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-08-27 19:28:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/513483002/60001

[commit-bot: I haz the power, 2014-08-27 20:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 20:25:57]

Failed to commit the patch.

[dmazzoni, 2014-08-28 15:14:33]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-08-28 15:16:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/513483002/60001

[commit-bot: I haz the power, 2014-08-28 15:38:10]

Committed patchset #4 (id:60001) as f21f1f359b0c650ce177cd07d7143ca4673bb626

[commit-bot: I haz the power, 2014-09-10 02:59:41]

Patchset 4 (id:??) landed as
https://crrev.com/c1ae0872e4c0336406ad47f6ab332174c3da80d5
Cr-Commit-Position: refs/heads/master@{#292386}