Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 513413003: Rebaseline ascii-supersets.html test (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
jsbell
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Rebaseline ascii-supersets.html test Shift_JIS is made to be compliant to the WHATWG encoding spec. Rebaseline ascii-supersets.html. BUG=277062 TEST=fast/encoding/api/ascii-supersets.html pass after ICU roll

Patch Set 1 #

Patch Set 2 : add a space at the end of the line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/fast/encoding/api/ascii-supersets-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
jungshik at Google
Will get landed after https://codereview.chromium.org/497543003/ is landed and ICU is rolled.
6 years, 3 months ago (2014-08-29 23:50:56 UTC) #2
jungshik at Google
6 years, 3 months ago (2014-08-29 23:51:01 UTC) #3
jsbell
lgtm!
6 years, 3 months ago (2014-09-02 18:32:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/513413003/20001
6 years, 3 months ago (2014-09-03 09:23:29 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/encoding/api/ascii-supersets-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-03 09:23:45 UTC) #8
jungshik at Google
tkent landed a rebaseline fix : https://codereview.chromium.org/535793003
6 years, 3 months ago (2014-09-03 09:25:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/513413003/20001
6 years, 3 months ago (2014-09-03 09:26:35 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 09:26:42 UTC) #14 
Failed to apply patch for
LayoutTests/fast/encoding/api/ascii-supersets-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/fast/encoding/api/ascii-supersets-expected.txt
  Hunk #1 FAILED at 32.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/fast/encoding/api/ascii-supersets-expected.txt.rej

Patch:       LayoutTests/fast/encoding/api/ascii-supersets-expected.txt
Index: LayoutTests/fast/encoding/api/ascii-supersets-expected.txt
diff --git a/LayoutTests/fast/encoding/api/ascii-supersets-expected.txt
b/LayoutTests/fast/encoding/api/ascii-supersets-expected.txt
index
eeffef2133249ad32ac3e363eb7b76e7c5e76215..db3c4e78ca41d04257f922e793e1954f5ba20a21
100644
--- a/LayoutTests/fast/encoding/api/ascii-supersets-expected.txt
+++ b/LayoutTests/fast/encoding/api/ascii-supersets-expected.txt
@@ -32,7 +32,7 @@ PASS ASCII superset encoding: gb18030
 PASS ASCII superset encoding: big5 
 PASS ASCII superset encoding: euc-jp 
 FAIL ASCII superset encoding: iso-2022-jp assert_equals: expected
"\0\x01\x02\x03\x04\x05\x06\x07\b\t\n\v\f\r\x0e\x0f\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1c\x1d\x1e\x1f
!\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~"
but got
"\0\x01\x02\x03\x04\x05\x06\x07\b\t\n\v\f\r��\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1c\x1d\x1e\x1f
!\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~"
-FAIL ASCII superset encoding: shift_jis assert_equals: expected
"\0\x01\x02\x03\x04\x05\x06\x07\b\t\n\v\f\r\x0e\x0f\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f
!\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~"
but got
"\0\x01\x02\x03\x04\x05\x06\x07\b\t\n\v\f\r\x0e\x0f\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1c\x1b\x1d\x1e\x1f
!\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~\x1a"
+PASS ASCII superset encoding: shift_jis 
 PASS ASCII superset encoding: euc-kr 
 PASS ASCII superset encoding: x-user-defined 
 Harness: the test ran to completion.

Powered by Google App Engine
This is Rietveld 408576698