Modify roll_dep's commit message

roll_dep.py

Index: roll_dep.py
diff --git a/roll_dep.py b/roll_dep.py
index c42d7d76eb8d5d9c214da8dc88512a63ab02d4f3..3b18852e7716f3b7495d6d53612c6084d24c0a19 100755
--- a/roll_dep.py
+++ b/roll_dep.py
@@ -27,6 +27,10 @@ from textwrap import dedent
 
 SHA1_RE = re.compile('^[a-fA-F0-9]{40}$')
 GIT_SVN_ID_RE = re.compile('^git-svn-id: .*@([0-9]+) .*$')
+ROLL_DESCRIPTION_STR = '''Roll %s from %s to %s
+
+Summary of changes available at: %s

[szager1, 2014/08/28 21:24:51]

Let's move the link to another line, to hopefully prevent overflow:

Summary of changes available at:
    %s

[borenet, 2014/08/29 13:32:02]

Done.

+'''
 
 
 def posix_path(path):
@@ -248,12 +252,8 @@ def generate_commit_message(deps_section, dep_name, new_rev):
   if url.endswith('.git'):
     url = url[:-4]
   url += '/+log/%s..%s' % (old_rev[:12], new_rev[:12])
-  return dedent('''\
-      Rolled %s
-          from revision %s
-          to revision %s
-      Summary of changes available at:
-          %s\n''' % (dep_name, old_rev, new_rev, url))
+  return dedent(ROLL_DESCRIPTION_STR % (
+      dep_name, old_rev[:12], new_rev[:12], url))

[szager1, 2014/08/28 21:23:15]

Can we use ellipses for over-long dep names?  Something like:

while len(dep_name) > 40:
  dep_name = '.../' + dep_name.lstrip('./').partition('/')[2]

[borenet, 2014/08/29 13:32:02]

Done.  Added a helper function since my intention is to have the AutoRoll Bot
import this file and use the ROLL_DESCRIPTION_STR directly when searching for
in-progress rolls.  Here's an example commit message where the dep_name was
shortened:

"""
Roll .../WebKit/LayoutTests/w3c/csswg-test from 0b12ea22689e to 198f08fb5364

Summary of changes available at:
   
https://chromium.googlesource.com/external/w3c/csswg-test/+log/0b12ea22689e.....
"""

The title line is under 80 chars, but the log link overflows.

 
 def update_deps_entry(deps_lines, deps_ast, value_node, new_rev, comment):
   line_idx = update_node(deps_lines, deps_ast, value_node, new_rev)