Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 513383002: Modify roll_dep's commit message (Closed)

Created:
6 years, 3 months ago by borenet
Modified:
6 years, 3 months ago
Reviewers:
szager, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Modify roll_dep's commit message This conforms to the convention of using a single-line short description followed by an empty line followed by a long description. Shortened the revisions to more easily fit on one line. BUG=408700 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291743

Patch Set 1 #

Total comments: 4

Patch Set 2 : szager's comments #

Total comments: 4

Patch Set 3 : more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M roll_dep.py View 1 2 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
borenet
borenet@google.com changed reviewers: + szager@google.com
6 years, 3 months ago (2014-08-28 20:07:53 UTC) #1
borenet
6 years, 3 months ago (2014-08-28 20:07:53 UTC) #2
szager1
szager@chromium.org changed reviewers: + szager@chromium.org
6 years, 3 months ago (2014-08-28 21:23:15 UTC) #3
szager1
https://codereview.chromium.org/513383002/diff/1/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/513383002/diff/1/roll_dep.py#newcode256 roll_dep.py:256: dep_name, old_rev[:12], new_rev[:12], url)) Can we use ellipses for ...
6 years, 3 months ago (2014-08-28 21:23:15 UTC) #4
szager1
https://codereview.chromium.org/513383002/diff/1/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/513383002/diff/1/roll_dep.py#newcode32 roll_dep.py:32: Summary of changes available at: %s Let's move the ...
6 years, 3 months ago (2014-08-28 21:24:52 UTC) #5
borenet
https://codereview.chromium.org/513383002/diff/1/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/513383002/diff/1/roll_dep.py#newcode32 roll_dep.py:32: Summary of changes available at: %s On 2014/08/28 21:24:51, ...
6 years, 3 months ago (2014-08-29 13:32:02 UTC) #6
szager1
lgtm % nits https://codereview.chromium.org/513383002/diff/20001/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/513383002/diff/20001/roll_dep.py#newcode33 roll_dep.py:33: %s Let's just get rid of ...
6 years, 3 months ago (2014-08-29 21:09:07 UTC) #7
borenet
Uploaded patch set 3. https://codereview.chromium.org/513383002/diff/20001/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/513383002/diff/20001/roll_dep.py#newcode33 roll_dep.py:33: %s On 2014/08/29 21:09:07, szager1 ...
6 years, 3 months ago (2014-08-29 21:14:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/513383002/40001
6 years, 3 months ago (2014-08-29 22:00:55 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 22:03:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 291743

Powered by Google App Engine
This is Rietveld 408576698