Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 513353002: Revert of Revert of ServiceWorker: throw when close() or terminate() called (Closed)

Created:
6 years, 3 months ago by jsbell
Modified:
6 years, 3 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of Revert of ServiceWorker: throw when close() or terminate() called (patchset #1 of https://codereview.chromium.org/515323002/) Reason for revert: The CL reverted by this patchset was not responsible for the breakage. Re-landing. Original issue's description: > Revert of ServiceWorker: throw when close() or terminate() called (patchset #3 of https://codereview.chromium.org/505063002/) > > Reason for revert: > Break compilation on various bots. Maybe Win only. > > Original issue's description: > > ServiceWorker: throw when close() or terminate() called > > > > Per spec: > > * ServiceWorker#terminate() should throw InvalidAccessError > > * ServiceWorkerGlobalScope#close() should throw InvalidAccessError > > > > ... since the behaviors inherited from the base interfaces are not > > supported. > > > > Spec: slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html > > > > BUG=398318 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181049 > > TBR=horo@chromium.org,jsbell@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=398318 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181050 TBR=horo@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=398318 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -7 lines) Patch
M LayoutTests/http/tests/serviceworker/interfaces.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-body-stream-worker.js View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-worker.js View 1 chunk +12 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/serviceworkerglobalscope-close-worker.js View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-close.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jsbell
Created Revert of Revert of ServiceWorker: throw when close() or terminate() called
6 years, 3 months ago (2014-08-28 19:22:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/513353002/1
6 years, 3 months ago (2014-08-28 19:23:39 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 19:24:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181057

Powered by Google App Engine
This is Rietveld 408576698