Add helper SkMatrix44::hasPerspective()

Add helper SkMatrix44::hasPerspective()

BUG=skia:997
R=reed@google.com,danakj@chromium.org

Committed: https://skia.googlesource.com/skia/+/a32f1758b7ebd889eecfdc67c935e7edcedc5be3

[tomhudson, 2014-08-28 19:15:33]

Small helper function requested by cc/ for legibility.

(And encapsulation, but I don't think we're going to update all of our clients
to hide the type flags at this time...)

[danakj, 2014-08-28 19:37:41]

https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h
File include/utils/SkMatrix44.h (right):

https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h#n...
include/utils/SkMatrix44.h:202: return !(this->getType() & ~kPerspective_Mask);
Don't you want (getType() & kPerspective_mask) ?

[tomhudson, 2014-08-28 19:47:52]

On 2014/08/28 19:37:41, danakj wrote:
> https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h
> File include/utils/SkMatrix44.h (right):
> 
>
https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h#n...
> include/utils/SkMatrix44.h:202: return !(this->getType() &
~kPerspective_Mask);
> Don't you want (getType() & kPerspective_mask) ?

Yeah, cut-and-paste error. My bad.
I'm importing the Chrome unit tests to Skia for http://skbug.com/997, perhaps I
should do that here, too.

[reed1, 2014-08-28 20:47:17]

https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h
File include/utils/SkMatrix44.h (right):

https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h#n...
include/utils/SkMatrix44.h:202: return !(this->getType() & ~kPerspective_Mask);
On 2014/08/28 19:37:41, danakj wrote:
> Don't you want (getType() & kPerspective_mask) ?

We use SkToBool(predicate) for this sort of thing.

    return SkToBool(this->getType() & kPerspective_Mask);

[tomhudson, 2014-08-29 15:32:57]

https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h
File include/utils/SkMatrix44.h (right):

https://codereview.chromium.org/513343002/diff/1/include/utils/SkMatrix44.h#n...
include/utils/SkMatrix44.h:202: return !(this->getType() & ~kPerspective_Mask);
On 2014/08/28 20:47:17, reed1 wrote:
> On 2014/08/28 19:37:41, danakj wrote:
> > Don't you want (getType() & kPerspective_mask) ?
> 
> We use SkToBool(predicate) for this sort of thing.
> 
>     return SkToBool(this->getType() & kPerspective_Mask);

Done.

[tomhudson, 2014-09-16 14:22:10]

Mike, ping for public API?

Now has unit tests. Will unblock minor cc/ cleanup.

[reed1, 2014-09-16 15:10:17]

lgtm

[tomhudson, 2014-09-16 15:21:05]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2014-09-16 15:21:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/513343002/20001

[commit-bot: I haz the power, 2014-09-16 15:29:32]

Committed patchset #2 (id:20001) as a32f1758b7ebd889eecfdc67c935e7edcedc5be3