media/cast/net/rtcp/rtcp.h - Issue 513313004: Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/net/rtcp/rtcp.h

Issue 513313004: Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/net/rtcp/rtcp.h

diff --git a/media/cast/net/rtcp/rtcp.h b/media/cast/net/rtcp/rtcp.h

index a1fdc9e4895d611c79b3d5a150563247b23e7a42..673e3895a1967bc8bd87a73a064425490560dab1 100644

--- a/media/cast/net/rtcp/rtcp.h

+++ b/media/cast/net/rtcp/rtcp.h

@@ -31,7 +31,7 @@ namespace cast {

class LocalRtcpReceiverFeedback;

class PacedPacketSender;

class RtcpReceiver;

-class RtcpSender;

+class RtcpBuilder;

typedef std::pair<uint32, base::TimeTicks> RtcpSendTimePair;

typedef std::map<uint32, base::TimeTicks> RtcpSendTimeMap;

@@ -138,7 +138,8 @@ class Rtcp {

const RtcpRttCallback rtt_callback_;

const RtcpLogMessageCallback log_callback_;

base::TickClock* const clock_; // Not owned by this class.

- const scoped_ptr<RtcpSender> rtcp_sender_;

+ const scoped_ptr<RtcpBuilder> rtcp_builder_;

miu 2014/09/03 22:28:07 nit: Can we use composition instead of pointer-to-

hubbe 2014/09/04 22:21:19 Oklidokli.

+ PacedPacketSender* packet_sender_; // Not owned.

const uint32 local_ssrc_;

const uint32 remote_ssrc_;

« no previous file with comments | « media/cast/cast_testing.gypi ('k') | media/cast/net/rtcp/rtcp.cc » ('j') | media/cast/net/rtcp/rtcp_builder.h » ('J')