Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 513293002: Roll cacheinvalidation DEPS to r339 (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
Nicolas Zea, Colin Meek
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nano-protobuf
Project:
chromium
Visibility:
Public.

Description

Roll cacheinvalidation DEPS to r339 Changes are needed for Chrome for Android using nano protobufs. Full list of changes: r339 Adding forwarding implementation of WakeLockManager in its original location (temporary workaround for Chromium) r338 * Updating example code to use nano protos instead of lite protos * Addressing Android lint warnings r337 Removing unused ticl.ProtoWrapper class and moving example code r336 Android cache invalidation client release August 2014 Depends on https://codereview.chromium.org/532303003/ BUG=377891 Committed: https://crrev.com/f50622c5c02be6cf7e0fd750d3a90b9672903e7f Cr-Commit-Position: refs/heads/master@{#293340}

Patch Set 1 #

Patch Set 2 : Add SVN rev comment #

Patch Set 3 : Roll to 339 #

Total comments: 2

Patch Set 4 : update readme #

Patch Set 5 : Fixed test issue #

Messages

Total messages: 19 (5 generated)
nyquist
nyquist@chromium.org changed reviewers: + meek@chromium.org
6 years, 3 months ago (2014-08-28 17:17:09 UTC) #1
nyquist
meek: PTAL
6 years, 3 months ago (2014-08-28 17:17:09 UTC) #2
Colin Meek
On 2014/08/28 17:17:09, nyquist wrote: > meek: PTAL LGTM!
6 years, 3 months ago (2014-08-28 17:31:41 UTC) #3
nyquist
nyquist@chromium.org changed reviewers: + zea@chromium.org
6 years, 3 months ago (2014-08-28 23:16:16 UTC) #4
nyquist
zea: PTAL
6 years, 3 months ago (2014-08-28 23:16:16 UTC) #5
Nicolas Zea
lgtm https://codereview.chromium.org/513293002/diff/40001/third_party/cacheinvalidation/README.chromium File third_party/cacheinvalidation/README.chromium (right): https://codereview.chromium.org/513293002/diff/40001/third_party/cacheinvalidation/README.chromium#newcode4 third_party/cacheinvalidation/README.chromium:4: Version: r338 339?
6 years, 3 months ago (2014-09-02 17:20:35 UTC) #6
nyquist
https://codereview.chromium.org/513293002/diff/40001/third_party/cacheinvalidation/README.chromium File third_party/cacheinvalidation/README.chromium (right): https://codereview.chromium.org/513293002/diff/40001/third_party/cacheinvalidation/README.chromium#newcode4 third_party/cacheinvalidation/README.chromium:4: Version: r338 On 2014/09/02 17:20:35, Nicolas Zea wrote: > ...
6 years, 3 months ago (2014-09-02 17:24:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/513293002/80001
6 years, 3 months ago (2014-09-04 15:14:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53537)
6 years, 3 months ago (2014-09-04 16:19:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/513293002/80001
6 years, 3 months ago (2014-09-04 16:43:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53587)
6 years, 3 months ago (2014-09-04 18:40:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/513293002/80001
6 years, 3 months ago (2014-09-04 19:47:38 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 026e26b0c90ff6b792db1f2962d8cbb25cfdbbab
6 years, 3 months ago (2014-09-04 21:34:45 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:47 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f50622c5c02be6cf7e0fd750d3a90b9672903e7f
Cr-Commit-Position: refs/heads/master@{#293340}

Powered by Google App Engine
This is Rietveld 408576698