Drop NaCl support for posting stdout/stderr to JS.

Drop NaCl support for posting stdout/stderr to JS.

After sending an email to the native-client-discuss list, it was determined
that this feature for redirecting stdout and stderr to JavaScript isn't very
useful. This drops support for that feature; a follow up change to the NaCl
repository will remove support there (and the SRPC message).

BUG=406558
Committed: https://crrev.com/6993b87a3ec9f5af3741acbb3bc53a73b0dd6a23
Cr-Commit-Position: refs/heads/master@{#293224}

[teravest, 2014-08-28 20:45:55]

teravest@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Mark Seaborn, 2014-08-28 21:05:02]

LGTM

Will you also remove the documentation for this feature from the docs in
native_client_sdk?

[teravest, 2014-08-28 21:09:11]

Sure, I can do that before submitting this.

On Thu, Aug 28, 2014 at 3:05 PM,  <mseaborn@chromium.org> wrote:
> LGTM
>
> Will you also remove the documentation for this feature from the docs in
> native_client_sdk?
>
> https://codereview.chromium.org/513273003/

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[teravest, 2014-08-28 21:09:11]

Sure, I can do that before submitting this.

On Thu, Aug 28, 2014 at 3:05 PM,  <mseaborn@chromium.org> wrote:
> LGTM
>
> Will you also remove the documentation for this feature from the docs in
> native_client_sdk?
>
> https://codereview.chromium.org/513273003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-09-03 15:11:04]

teravest@chromium.org changed reviewers:
+ binji@chromium.org

[teravest, 2014-09-03 15:11:05]

+binji for native_client_sdk

I may as well make the documentation update in the same change since the docs
are in the Chromium repository. I had thought the docs were stored elsewhere.

[Mark Seaborn, 2014-09-03 15:16:39]

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (left):

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/devguide/devcycle/debugging.rst:117: Redirecting
output to the JavaScript console
The generated HTML is checked in. :-(  You need to run "make chromesite_rst"
from native_client_sdk/src/doc/ to regenerate it.

[JF, 2014-09-03 15:22:05]

jfb@chromium.org changed reviewers:
+ jfb@chromium.org, jmedley@chromium.org

[JF, 2014-09-03 15:22:06]

Adding Joe to the review.

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right):

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/devguide/devcycle/debugging.rst:71: JavaScript
`console </devtools/docs/console-api>`_ in Chrome's Developer Tools.
Do we have an example of doing this? It's pretty much the same as the feature
you're removing, but without the helpful example.

[jpmedley, 2014-09-03 15:31:10]

Run make chromesite_rst. Otherwise LGTM.

[teravest, 2014-09-03 16:56:49]

I ran "make chromesite_rst" to generate some documentation.

I found that some other files were being touched locally and reverted those
changes locally-- it seems that I've got something misconfigured that's causing
community/index.html and pepper_stable/index.html to have some different href
values.

The generated debuggging.html in here looks pretty reasonable to me, but please
let me know if something looks awry.

[teravest, 2014-09-03 16:58:32]

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right):

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/devguide/devcycle/debugging.rst:71: JavaScript
`console </devtools/docs/console-api>`_ in Chrome's Developer Tools.
On 2014/09/03 15:22:06, JF wrote:
> Do we have an example of doing this? It's pretty much the same as the feature
> you're removing, but without the helpful example.

There are examples of using PostMessage available in the linked document:
  https://developer.chrome.com/native-client/devguide/coding/message-system

But there's not a quick example of doing this for debugging in this document.

[JF, 2014-09-03 17:03:01]

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right):

https://codereview.chromium.org/513273003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/devguide/devcycle/debugging.rst:71: JavaScript
`console </devtools/docs/console-api>`_ in Chrome's Developer Tools.
On 2014/09/03 16:58:32, teravest wrote:
> On 2014/09/03 15:22:06, JF wrote:
> > Do we have an example of doing this? It's pretty much the same as the
feature
> > you're removing, but without the helpful example.
> 
> There are examples of using PostMessage available in the linked document:
>   https://developer.chrome.com/native-client/devguide/coding/message-system
> 
> But there's not a quick example of doing this for debugging in this document.

Could you add one? This is a pretty basic functionality for porting code, so
having something that's simply copy/paste-able makes getting started much nicer
for our users IMO.

[Mark Seaborn, 2014-09-03 17:08:54]

On 3 September 2014 10:03, <jfb@chromium.org> wrote:

>
> https://codereview.chromium.org/513273003/diff/20001/
> native_client_sdk/src/doc/devguide/devcycle/debugging.rst
> File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right):
>
> https://codereview.chromium.org/513273003/diff/20001/
> native_client_sdk/src/doc/devguide/devcycle/debugging.rst#newcode71
> native_client_sdk/src/doc/devguide/devcycle/debugging.rst:71: JavaScript
> `console </devtools/docs/console-api>`_ in Chrome's Developer Tools.
> On 2014/09/03 16:58:32, teravest wrote:
>
>> On 2014/09/03 15:22:06, JF wrote:
>> > Do we have an example of doing this? It's pretty much the same as
>>
> the feature
>
>> > you're removing, but without the helpful example.
>>
>
>  There are examples of using PostMessage available in the linked
>>
> document:
>
> https://developer.chrome.com/native-client/devguide/coding/message-system
>
>  But there's not a quick example of doing this for debugging in this
>>
> document.
>
> Could you add one? This is a pretty basic functionality for porting
> code, so having something that's simply copy/paste-able makes getting
> started much nicer for our users IMO.


If you do add one, maybe you could split the doc change into a separate CL?

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Mark Seaborn, 2014-09-03 17:08:54]

On 3 September 2014 10:03, <jfb@chromium.org> wrote:

>
> https://codereview.chromium.org/513273003/diff/20001/
> native_client_sdk/src/doc/devguide/devcycle/debugging.rst
> File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right):
>
> https://codereview.chromium.org/513273003/diff/20001/
> native_client_sdk/src/doc/devguide/devcycle/debugging.rst#newcode71
> native_client_sdk/src/doc/devguide/devcycle/debugging.rst:71: JavaScript
> `console </devtools/docs/console-api>`_ in Chrome's Developer Tools.
> On 2014/09/03 16:58:32, teravest wrote:
>
>> On 2014/09/03 15:22:06, JF wrote:
>> > Do we have an example of doing this? It's pretty much the same as
>>
> the feature
>
>> > you're removing, but without the helpful example.
>>
>
>  There are examples of using PostMessage available in the linked
>>
> document:
>
> https://developer.chrome.com/native-client/devguide/coding/message-system
>
>  But there's not a quick example of doing this for debugging in this
>>
> document.
>
> Could you add one? This is a pretty basic functionality for porting
> code, so having something that's simply copy/paste-able makes getting
> started much nicer for our users IMO.


If you do add one, maybe you could split the doc change into a separate CL?

Cheers,
Mark

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-09-03 18:14:19]

I've removed the documentation changes from this issue.

Since I was having issues with generating docs, jmedley@ was kind enough to
remove that documentation section for me:
  https://codereview.chromium.org/530173003/

JF,
I'll write a (short) example and add some PostMessage documentation in another
change, to prevent too much discussion from happening here.

Sound good?

[JF, 2014-09-03 18:27:56]

>
> JF,
> I'll write a (short) example and add some PostMessage documentation in
> another
> change, to prevent too much discussion from happening here.
>
> Sound good?
>

sgtm, the change lgtm overall, but I'm not qualified to review Pepper
things.

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[JF, 2014-09-03 18:27:56]

>
> JF,
> I'll write a (short) example and add some PostMessage documentation in
> another
> change, to prevent too much discussion from happening here.
>
> Sound good?
>

sgtm, the change lgtm overall, but I'm not qualified to review Pepper
things.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-09-03 19:09:58]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-09-03 19:10:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/513273003/60001

[commit-bot: I haz the power, 2014-09-03 21:22:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 23:51:38]

Committed patchset #4 (id:60001) as 51bd89c05804633cda2ec7b229b4c75b4585635c

[commit-bot: I haz the power, 2014-09-10 03:28:39]

Patchset 4 (id:??) landed as
https://crrev.com/6993b87a3ec9f5af3741acbb3bc53a73b0dd6a23
Cr-Commit-Position: refs/heads/master@{#293224}