Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: runtime/vm/locations.h

Issue 513213002: Generate some intrinsics using our IR. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/locations.h
===================================================================
--- runtime/vm/locations.h (revision 39726)
+++ runtime/vm/locations.h (working copy)
@@ -282,9 +282,16 @@
return static_cast<uword>(kStackIndexBias + stack_index);
}
+ enum StackSlotBase {
+ kFpRelative,
+ kSpRelative
+ };
+
// Spill slots.
- static Location StackSlot(intptr_t stack_index) {
- uword payload = EncodeStackIndex(stack_index);
+ static Location StackSlot(intptr_t stack_index,
+ Register base = FPREG) {
+ uword payload = StackSlotBaseField::encode(base)
+ | StackIndexField::encode(EncodeStackIndex(stack_index));
Location loc(kStackSlot, payload);
// Ensure that sign is preserved.
ASSERT(loc.stack_index() == stack_index);
@@ -296,7 +303,8 @@
}
static Location DoubleStackSlot(intptr_t stack_index) {
- uword payload = EncodeStackIndex(stack_index);
+ uword payload = StackSlotBaseField::encode(FPREG)
+ | StackIndexField::encode(EncodeStackIndex(stack_index));
Location loc(kDoubleStackSlot, payload);
// Ensure that sign is preserved.
ASSERT(loc.stack_index() == stack_index);
@@ -308,7 +316,8 @@
}
static Location QuadStackSlot(intptr_t stack_index) {
- uword payload = EncodeStackIndex(stack_index);
+ uword payload = StackSlotBaseField::encode(FPREG)
+ | StackIndexField::encode(EncodeStackIndex(stack_index));
Location loc(kQuadStackSlot, payload);
// Ensure that sign is preserved.
ASSERT(loc.stack_index() == stack_index);
@@ -319,10 +328,15 @@
return kind() == kQuadStackSlot;
}
+ Register base_reg() const {
+ ASSERT(HasStackIndex());
+ return StackSlotBaseField::decode(payload());
+ }
+
intptr_t stack_index() const {
ASSERT(HasStackIndex());
// Decode stack index manually to preserve sign.
- return payload() - kStackIndexBias;
+ return StackIndexField::decode(payload()) - kStackIndexBias;
}
bool HasStackIndex() const {
@@ -378,8 +392,16 @@
typedef BitField<Policy, 0, 3> PolicyField;
// Layout for stack slots.
+ static const intptr_t kBitsForBaseReg = 5;
+ static const intptr_t kBitsForStackIndex = kBitsForPayload - kBitsForBaseReg;
+ typedef BitField<Register, 0, kBitsForBaseReg> StackSlotBaseField;
+ typedef BitField<intptr_t,
+ kBitsForBaseReg,
+ kBitsForStackIndex> StackIndexField;
+ COMPILE_ASSERT(1 << kBitsForBaseReg >= kNumberOfCpuRegisters);
+
static const intptr_t kStackIndexBias =
- static_cast<intptr_t>(1) << (kBitsForPayload - 1);
+ static_cast<intptr_t>(1) << (kBitsForStackIndex - 1);
// Location either contains kind and payload fields or a tagged handle for
// a constant locations. Values of enumeration Kind are selected in such a

Powered by Google App Engine
This is Rietveld 408576698