Generate some intrinsics using our IR.

runtime/vm/intrinsifier_arm.cc

Index: runtime/vm/intrinsifier_arm.cc
===================================================================
--- runtime/vm/intrinsifier_arm.cc	(revision 39909)
+++ runtime/vm/intrinsifier_arm.cc	(working copy)
@@ -22,45 +22,9 @@
 #define __ assembler->
 
 
-void Intrinsifier::ObjectArrayLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, Array::length_offset()));
-  __ Ret();
-}
+intptr_t Intrinsifier::ParameterSlotFromSp() { return -1; }

[zra, 2014/09/05 20:26:52]

Maybe add a constant to stack_frame_*.h

[Florian Schneider, 2014/09/08 11:12:40]

This is specific for intrinsics, so it seems not useful for other places.

 
 
-void Intrinsifier::ImmutableArrayLength(Assembler* assembler) {
-  ObjectArrayLength(assembler);
-}
-
-
-void Intrinsifier::ObjectArrayGetIndexed(Assembler* assembler) {
-  Label fall_through;
-
-  __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index
-  __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array
-
-  __ tst(R0, Operand(kSmiTagMask));
-  __ b(&fall_through, NE);  // Index is not an smi, fall through
-
-  // Range check.
-  __ ldr(R6, FieldAddress(R1, Array::length_offset()));
-  __ cmp(R0, Operand(R6));
-
-  ASSERT(kSmiTagShift == 1);
-  // array element at R1 + R0*2 + Array::data_offset - 1
-  __ add(R6, R1, Operand(R0, LSL, 1), CC);
-  __ ldr(R0, FieldAddress(R6, Array::data_offset()), CC);
-  __ bx(LR, CC);
-  __ Bind(&fall_through);
-}
-
-
-void Intrinsifier::ImmutableArrayGetIndexed(Assembler* assembler) {
-  ObjectArrayGetIndexed(assembler);
-}
-
-
 static intptr_t ComputeObjectArrayTypeArgumentsOffset() {
   const Library& core_lib = Library::Handle(Library::CoreLibrary());
   const Class& cls = Class::Handle(
@@ -173,21 +137,6 @@
 }
 
 
-void Intrinsifier::GrowableArrayLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, GrowableObjectArray::length_offset()));
-  __ Ret();
-}
-
-
-void Intrinsifier::GrowableArrayCapacity(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, GrowableObjectArray::data_offset()));
-  __ ldr(R0, FieldAddress(R0, Array::length_offset()));
-  __ Ret();
-}
-
-
 void Intrinsifier::GrowableArrayGetIndexed(Assembler* assembler) {
   Label fall_through;
 
@@ -392,134 +341,6 @@
   __ Bind(&fall_through);                                                      \
 
 
-// Gets the length of a TypedData.
-void Intrinsifier::TypedDataLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, TypedData::length_offset()));
-  __ Ret();
-}
-
-
-void Intrinsifier::Uint8ArrayGetIndexed(Assembler* assembler) {
-  Label fall_through;
-  __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
-  __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
-  __ tst(R0, Operand(kSmiTagMask));
-  __ b(&fall_through, NE);  // Index is not a smi, fall through.
-
-  // Range check.
-  __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
-  __ cmp(R0, Operand(R6));
-  __ b(&fall_through, CS);
-
-  __ SmiUntag(R0);
-  __ AddImmediate(R1, TypedData::data_offset() - kHeapObjectTag);
-  __ ldrb(R0, Address(R1, R0));
-  __ SmiTag(R0);
-  __ Ret();
-  __ Bind(&fall_through);
-}
-
-
-void Intrinsifier::ExternalUint8ArrayGetIndexed(Assembler* assembler) {
-  Label fall_through;
-
-  __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
-  __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
-  __ tst(R0, Operand(kSmiTagMask));
-  __ b(&fall_through, NE);  // Index is not a smi, fall through.
-
-  // Range check.
-  __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
-  __ cmp(R0, Operand(R6));
-  __ b(&fall_through, CS);
-
-  __ LoadFromOffset(kWord, R1, R1,
-      ExternalTypedData::data_offset() - kHeapObjectTag);
-  __ SmiUntag(R0);
-  __ ldrb(R0, Address(R1, R0));
-  __ SmiTag(R0);
-  __ Ret();
-  __ Bind(&fall_through);
-}
-
-
-void Intrinsifier::Float64ArrayGetIndexed(Assembler* assembler) {
-  if (!TargetCPUFeatures::vfp_supported()) {
-    return;
-  }
-  Label fall_through;
-  __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
-  __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
-  __ tst(R0, Operand(kSmiTagMask));
-  __ b(&fall_through, NE);  // Index is not a smi, fall through.
-
-  // Range check.
-  __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
-  __ cmp(R0, Operand(R6));
-  __ b(&fall_through, CS);
-
-
-  Address element_address =
-      __ ElementAddressForRegIndex(true,  // Load.
-                                   false,  // Not external.
-                                   kTypedDataFloat64ArrayCid,  // Cid.
-                                   8,  // Index scale.
-                                   R1,  // Array.
-                                   R0);  // Index.
-
-  __ vldrd(D0, element_address);
-
-  const Class& double_class = Class::Handle(
-      Isolate::Current()->object_store()->double_class());
-  __ TryAllocate(double_class,
-                 &fall_through,
-                 R0,  // Result register.
-                 R1);
-  __ StoreDToOffset(D0, R0, Double::value_offset() - kHeapObjectTag);
-  __ Ret();
-  __ Bind(&fall_through);
-}
-
-
-void Intrinsifier::Float64ArraySetIndexed(Assembler* assembler) {
-  if (!TargetCPUFeatures::vfp_supported()) {
-    return;
-  }
-  Label fall_through;
-  __ ldr(R0, Address(SP, + 1 * kWordSize));  // Index.
-  __ ldr(R1, Address(SP, + 2 * kWordSize));  // Array.
-  __ tst(R0, Operand(kSmiTagMask));
-  __ b(&fall_through, NE);  // Index is not a smi, fall through.
-
-  // Range check.
-  __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
-  __ cmp(R0, Operand(R6));
-  __ b(&fall_through, CS);
-
-  __ ldr(R2, Address(SP, + 0 * kWordSize));  // Value.
-  __ tst(R2, Operand(kSmiTagMask));
-  __ b(&fall_through, EQ);  // Value is Smi, fall through.
-
-  __ LoadClassId(R3, R2);
-  __ CompareImmediate(R3, kDoubleCid);
-  __ b(&fall_through, NE);  // Not a Double, fall through.
-
-  __ LoadDFromOffset(D0, R2, Double::value_offset() - kHeapObjectTag);
-
-  Address element_address =
-      __ ElementAddressForRegIndex(false,  // Store.
-                                   false,  // Not external.
-                                   kTypedDataFloat64ArrayCid,  // Cid.
-                                   8,  // Index scale.
-                                   R1,  // Array.
-                                   R0);  // Index.
-  __ vstrd(D0, element_address);
-  __ Ret();
-  __ Bind(&fall_through);
-}
-
-
 static int GetScaleFactor(intptr_t size) {
   switch (size) {
     case 1: return 0;
@@ -1372,13 +1193,6 @@
 }
 
 
-void Intrinsifier::StringBaseLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, String::length_offset()));
-  __ Ret();
-}
-
-
 void Intrinsifier::StringBaseCodeUnitAt(Assembler* assembler) {
   Label fall_through, try_two_byte_string;