Generate some intrinsics using our IR.

runtime/vm/assembler_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/heap.h"
 #include "vm/locations.h"
 #include "vm/memory_region.h"
 #include "vm/runtime_entry.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, print_stop_message, true, "Print stop message.");
 DECLARE_FLAG(bool, inline_alloc);
 
 
 Assembler::Assembler(bool use_far_branches)
     : buffer_(),
       object_pool_(GrowableObjectArray::Handle()),
       patchable_pool_entries_(),
       prologue_offset_(-1),
-      comments_() {
+      comments_(),
+      allow_constant_pool_(true) {
   // Far branching mode is only needed and implemented for MIPS and ARM.
   ASSERT(!use_far_branches);
   Isolate* isolate = Isolate::Current();
   if (isolate != Dart::vm_isolate()) {
     object_pool_ = GrowableObjectArray::New(Heap::kOld);
 
     // These objects and labels need to be accessible through every pool-pointer
     // at the same index.
     object_pool_.Add(Object::null_object(), Heap::kOld);
     patchable_pool_entries_.Add(kNotPatchable);
@@ skipping 102 matching lines @@
     AssemblerBuffer::EnsureCapacity ensured(&buffer_);
     EmitRegisterREX(TMP, REX_W);
     EmitUint8(0xB8 | (TMP & 7));
     EmitInt64(label->address());
   }
   call(TMP);
 }
 
 
 void Assembler::CallPatchable(const ExternalLabel* label) {
   intptr_t call_start = buffer_.GetPosition();

[zra, 2014/09/05 20:26:49]

ASSERT that the constant pool is enabled, o/w this won't really be patchable.

[Florian Schneider, 2014/09/08 11:12:39]

Done.

   LoadExternalLabel(TMP, label, kPatchable, PP);
   call(TMP);
   ASSERT((buffer_.GetPosition() - call_start) == kCallExternalLabelSize);
 }
 
 
 void Assembler::Call(const ExternalLabel* label, Register pp) {
   if (Isolate::Current() == Dart::vm_isolate()) {
     call(label);
   } else {
@@ skipping 2199 matching lines @@
     AssemblerBuffer::EnsureCapacity ensured(&buffer_);
     EmitRegisterREX(TMP, REX_W);
     EmitUint8(0xB8 | (TMP & 7));
     EmitInt64(label->address());
   }
   jmp(TMP);
 }
 
 
 void Assembler::JmpPatchable(const ExternalLabel* label, Register pp) {
   intptr_t call_start = buffer_.GetPosition();

[zra, 2014/09/05 20:26:49]

Assert that the constant pool is enabled, o/w this won't really be patchable.

[Florian Schneider, 2014/09/08 11:12:39]

Done.

   LoadExternalLabel(TMP, label, kPatchable, pp);
   jmp(TMP);
   ASSERT((buffer_.GetPosition() - call_start) == kCallExternalLabelSize);
 }
 
 
 void Assembler::Jmp(const ExternalLabel* label, Register pp) {
   LoadExternalLabel(TMP, label, kNotPatchable, pp);
   jmp(TMP);
 }
@@ skipping 200 matching lines @@
   }
   // If the call is patchable, do not reuse an existing entry since each
   // reference may be patched independently.
   object_pool_.Add(smi, Heap::kOld);
   patchable_pool_entries_.Add(patchable);
   return object_pool_.Length() - 1;
 }
 
 
 bool Assembler::CanLoadFromObjectPool(const Object& object) {
+  if (!allow_constant_pool()) return false;

[zra, 2014/09/05 20:26:49]

Please use curly braces.

Also, Null, True, and False should be loaded from the pool even if this flag is
false since they are in every constant pool.

[Florian Schneider, 2014/09/08 11:12:39]

What about the case of an intrinsified function directly invoked from C++? - it
won't have a constant pool register set up from the caller.

[Florian Schneider, 2014/09/08 11:13:56]

Never mind. For the set of VM objects it still works fine since PP is set up in
the invocation stub.

+
   // TODO(zra, kmillikin): Also load other large immediates from the object
   // pool
   if (object.IsSmi()) {
     // If the raw smi does not fit into a 32-bit signed int, then we'll keep
     // the raw value in the object pool.
     return !Utils::IsInt(32, reinterpret_cast<int64_t>(object.raw()));
   }
   ASSERT(object.IsNotTemporaryScopedHandle());
   ASSERT(object.IsOld());
   return (Isolate::Current() != Dart::vm_isolate()) &&
@@ skipping 63 matching lines @@
 
 intptr_t Assembler::FindImmediate(int64_t imm) {
   ASSERT(Isolate::Current() != Dart::vm_isolate());
   ASSERT(!object_pool_.IsNull());
   const Smi& smi = Smi::Handle(reinterpret_cast<RawSmi*>(imm));
   return FindObject(smi, kNotPatchable);
 }
 
 
 bool Assembler::CanLoadImmediateFromPool(const Immediate& imm, Register pp) {
+  if (!allow_constant_pool()) return false;

[zra, 2014/09/05 20:26:50]

Please use curly braces.

[Florian Schneider, 2014/09/08 11:12:39]

Done.

   return !imm.is_int32() &&
          (pp != kNoRegister) &&
          (Isolate::Current() != Dart::vm_isolate());
 }
 
 
 void Assembler::LoadImmediate(Register reg, const Immediate& imm, Register pp) {
   if (CanLoadImmediateFromPool(imm, pp)) {
     // It's a 64-bit constant and we're not in the VM isolate, so load from
     // object pool.
@@ skipping 838 matching lines @@
 
 
 const char* Assembler::FpuRegisterName(FpuRegister reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
   return xmm_reg_names[reg];
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64