Generate some intrinsics using our IR.

runtime/vm/assembler_arm64.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_ARM64)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/longjump.h"
@@ skipping 13 matching lines @@
 DEFINE_FLAG(bool, print_stop_message, false, "Print stop message.");
 DECLARE_FLAG(bool, inline_alloc);
 
 
 Assembler::Assembler(bool use_far_branches)
     : buffer_(),
       object_pool_(GrowableObjectArray::Handle()),
       patchable_pool_entries_(),
       prologue_offset_(-1),
       use_far_branches_(use_far_branches),
-      comments_() {
+      comments_(),
+      allow_constant_pool_(true) {
   if (Isolate::Current() != Dart::vm_isolate()) {
     object_pool_ = GrowableObjectArray::New(Heap::kOld);
 
     // These objects and labels need to be accessible through every pool-pointer
     // at the same index.
     object_pool_.Add(Object::null_object(), Heap::kOld);
     patchable_pool_entries_.Add(kNotPatchable);
     // Not adding Object::null() to the index table. It is at index 0 in the
     // object pool, but the HashMap uses 0 to indicate not found.
 
@@ skipping 436 matching lines @@
 
 intptr_t Assembler::FindImmediate(int64_t imm) {
   ASSERT(Isolate::Current() != Dart::vm_isolate());
   ASSERT(!object_pool_.IsNull());
   const Smi& smi = Smi::Handle(reinterpret_cast<RawSmi*>(imm));
   return FindObject(smi, kNotPatchable);
 }
 
 
 bool Assembler::CanLoadObjectFromPool(const Object& object) {
+  if (!allow_constant_pool()) return false;

[zra, 2014/09/05 20:26:49]

Please use curly braces.

Also, Null, True, and False should be loaded from the pool even if this flag is
false since they are in every constant pool.

[Florian Schneider, 2014/09/08 11:12:39]

Ok, I made those objects to be loaded from the constant pool

+
   // TODO(zra, kmillikin): Also load other large immediates from the object
   // pool
   if (object.IsSmi()) {
     // If the raw smi does not fit into a 32-bit signed int, then we'll keep
     // the raw value in the object pool.
     return !Utils::IsInt(32, reinterpret_cast<int64_t>(object.raw()));
   }
   ASSERT(object.IsNotTemporaryScopedHandle());
   ASSERT(object.IsOld());
   return (Isolate::Current() != Dart::vm_isolate()) &&
          // Not in the VMHeap, OR is one of the VMHeap objects we put in every
          // object pool.
          // TODO(zra): Evaluate putting all VM heap objects into the pool.
          (!object.InVMHeap() || (object.raw() == Object::null()) ||
                                 (object.raw() == Bool::True().raw()) ||
                                 (object.raw() == Bool::False().raw()));
 }
 
 
 bool Assembler::CanLoadImmediateFromPool(int64_t imm, Register pp) {
+  if (!allow_constant_pool()) return false;

[zra, 2014/09/05 20:26:49]

Please use curly braces.

[Florian Schneider, 2014/09/08 11:12:39]

Done.

   return !Utils::IsInt(32, imm) &&
          (pp != kNoPP) &&
          // We *could* put constants in the pool in a VM isolate, but it is
          // simpler to maintain the invariant that the object pool is not used
          // in the VM isolate.
          (Isolate::Current() != Dart::vm_isolate());
 }
 
 
 void Assembler::LoadExternalLabel(Register dst,
@@ skipping 39 matching lines @@
   if (CanLoadObjectFromPool(object)) {
     LoadObject(TMP, object, pp);
     CompareRegisters(reg, TMP);
   } else {
     CompareImmediate(reg, reinterpret_cast<int64_t>(object.raw()), pp);
   }
 }
 
 
 void Assembler::LoadDecodableImmediate(Register reg, int64_t imm, Register pp) {
-  if ((pp != kNoPP) && (Isolate::Current() != Dart::vm_isolate())) {
+  if ((pp != kNoPP) &&
+      (Isolate::Current() != Dart::vm_isolate()) &&
+      allow_constant_pool()) {
     int64_t val_smi_tag = imm & kSmiTagMask;
     imm &= ~kSmiTagMask;  // Mask off the tag bits.
     const int32_t offset = Array::element_offset(FindImmediate(imm));
     LoadWordFromPoolOffset(reg, pp, offset);
     if (val_smi_tag != 0) {
       // Add back the tag bits.
       orri(reg, reg, val_smi_tag);
     }
   } else {
     // TODO(zra): Since this sequence only needs to be decodable, it can be
@@ skipping 911 matching lines @@
     add(base, array, Operand(index, LSL, shift));
   }
   const OperandSize size = Address::OperandSizeFor(cid);
   ASSERT(Address::CanHoldOffset(offset, Address::Offset, size));
   return Address(base, offset, Address::Offset, size);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM64