Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 513183002: Adding option for Stop/Reload in location bar for content shell. (Closed)

Created:
6 years, 3 months ago by ankit
Modified:
6 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding option for Stop/Reload in location bar. Currently reload/stop button is not present in content shell. If user has to do reload operation then only option to do that is select the url bar and click go button.Similarly stop button is not present. To stop loading of page only option is to press back button. Added code to support stop/reload option. BUG= Committed: https://crrev.com/571ce25c3bc86a62e76e2fa02c18c44e143cc792 Cr-Commit-Position: refs/heads/master@{#292778}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nits resolved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A content/shell/android/java/res/drawable/ic_refresh.png View Binary file 0 comments Download
M content/shell/android/java/res/layout/shell_view.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 1 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ankit
ankit2.kumar@samsung.com changed reviewers: + tedchoc@chromium.org
6 years, 3 months ago (2014-08-28 12:18:29 UTC) #1
ankit
On 2014/08/28 12:18:29, ankit wrote: > mailto:ankit2.kumar@samsung.com changed reviewers: > + mailto:tedchoc@chromium.org PTAL
6 years, 3 months ago (2014-08-28 12:18:39 UTC) #2
Ted C
lgtm w/ nit https://codereview.chromium.org/513183002/diff/1/content/shell/android/java/src/org/chromium/content_shell/Shell.java File content/shell/android/java/src/org/chromium/content_shell/Shell.java (right): https://codereview.chromium.org/513183002/diff/1/content/shell/android/java/src/org/chromium/content_shell/Shell.java#newcode223 content/shell/android/java/src/org/chromium/content_shell/Shell.java:223: mContentViewCore.stopLoading(); in java, braces are required ...
6 years, 3 months ago (2014-08-28 16:21:14 UTC) #3
ankit
On 2014/08/28 16:21:14, Ted C wrote: > lgtm w/ nit > > https://codereview.chromium.org/513183002/diff/1/content/shell/android/java/src/org/chromium/content_shell/Shell.java > File ...
6 years, 3 months ago (2014-08-28 17:30:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/513183002/20001
6 years, 3 months ago (2014-08-30 04:54:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1582b16fa03c9b12578ebb1deaabcac19a802d59
6 years, 3 months ago (2014-08-30 05:51:54 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/571ce25c3bc86a62e76e2fa02c18c44e143cc792
Cr-Commit-Position: refs/heads/master@{#292778}

Powered by Google App Engine
This is Rietveld 408576698