Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 513173002: Fix strict mode violation in Android WebView. (Closed)

Created:
6 years, 3 months ago by benm (inactive)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix strict mode violations in Android. BUG=408525 Committed: https://crrev.com/6dc7551d1f0023f2b3e80eb54a8deec88b7778fb Cr-Commit-Position: refs/heads/master@{#292380}

Patch Set 1 #

Patch Set 2 : fix some more warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwAssets.java View 1 chunk +11 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java View 1 8 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
benm (inactive)
benm@chromium.org changed reviewers: + primiano@google.com
6 years, 3 months ago (2014-08-28 12:07:38 UTC) #1
benm (inactive)
ptal
6 years, 3 months ago (2014-08-28 12:07:38 UTC) #2
benm (inactive)
benm@chromium.org changed reviewers: + torne@chromium.org
6 years, 3 months ago (2014-08-28 13:42:42 UTC) #3
benm (inactive)
6 years, 3 months ago (2014-08-28 13:42:42 UTC) #4
Torne
lgtm
6 years, 3 months ago (2014-08-28 14:07:18 UTC) #5
benm (inactive)
The CQ bit was checked by benm@chromium.org
6 years, 3 months ago (2014-08-28 14:09:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/513173002/20001
6 years, 3 months ago (2014-08-28 14:10:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6c4efa4876f1397b51d4e067d73ecb202b860147
6 years, 3 months ago (2014-08-28 14:49:10 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dc7551d1f0023f2b3e80eb54a8deec88b7778fb
Cr-Commit-Position: refs/heads/master@{#292380}

Powered by Google App Engine
This is Rietveld 408576698