Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 513143004: Renaming CreateShillConfiguration argument for clarification. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Renaming CreateShillConfiguration argument for clarification. Renaming from 'settings' to the more informative 'user_settings'. BUG=NONE Committed: https://crrev.com/c8b8dfb514892494f9d61e24117410e825816dd4 Cr-Commit-Position: refs/heads/master@{#292407}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chromeos/network/policy_applicator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/network/policy_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/network/policy_util.cc View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pneubeck (no reviews)
pneubeck@chromium.org changed reviewers: + stevenjb@chromium.org
6 years, 3 months ago (2014-08-28 10:13:24 UTC) #1
pneubeck (no reviews)
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-28 10:15:06 UTC) #2
pneubeck (no reviews)
ptal
6 years, 3 months ago (2014-08-28 10:15:36 UTC) #3
stevenjb
lgtm
6 years, 3 months ago (2014-08-28 15:50:49 UTC) #4
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 3 months ago (2014-08-28 16:01:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/513143004/20001
6 years, 3 months ago (2014-08-28 16:02:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as c067e672f5ae7ad61dbebbc98aa9b4ef7df2c85a
6 years, 3 months ago (2014-08-28 17:08:44 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:22 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c8b8dfb514892494f9d61e24117410e825816dd4
Cr-Commit-Position: refs/heads/master@{#292407}

Powered by Google App Engine
This is Rietveld 408576698