Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: components/search_engines/template_url_fetcher_unittest.cc

Issue 513133002: Move TemplateURLService related tests to components/search_engines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_fetcher_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_fetcher_unittest.cc b/components/search_engines/template_url_fetcher_unittest.cc
similarity index 98%
rename from chrome/browser/search_engines/template_url_fetcher_unittest.cc
rename to components/search_engines/template_url_fetcher_unittest.cc
index 3a51253b9df1742534eea39d0b9d27065118ac25..b8944251cd016ba46cede7638a584a26c558222e 100644
--- a/chrome/browser/search_engines/template_url_fetcher_unittest.cc
+++ b/components/search_engines/template_url_fetcher_unittest.cc
@@ -14,6 +14,7 @@
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_fetcher.h"
#include "components/search_engines/template_url_service.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
@@ -57,6 +58,7 @@ class TemplateURLFetcherTest : public testing::Test {
// Waits for any downloads to finish.
void WaitForDownloadToFinish();
+ content::TestBrowserThreadBundle thread_bundle_;
Peter Kasting 2014/08/28 19:06:20 Nit: Add comments about why we need this. While h
hashimoto 2014/08/29 08:06:26 Added comments and made all data members private.
TemplateURLServiceTestUtil test_util_;
scoped_ptr<TemplateURLFetcher> template_url_fetcher_;
net::test_server::EmbeddedTestServer test_server_;
@@ -79,7 +81,8 @@ class TemplateURLFetcherTest : public testing::Test {
};
TemplateURLFetcherTest::TemplateURLFetcherTest()
- : callbacks_destroyed_(0),
+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
+ callbacks_destroyed_(0),
add_provider_called_(0),
waiting_for_download_(false) {
base::FilePath src_dir;

Powered by Google App Engine
This is Rietveld 408576698