Move TemplateURLService related tests to components/search_engines

Move TemplateURLService related tests to components/search_engines

Put tests next to the code being tested.

Move tests to components/ without actually removing dependencies with temporary DEPS rules added.
This results in these tests still built as parts of unit_tests, not components_unittests.

Fix TemplateURLServiceTestUtil to simplify the code and reduce chrome dependencies:
- Create KeywordWebDataService instead of depending on WebDataServiceFactory.
- Remove TemplateURLService::SetKeywordSearchTermsForURL() and TestingTemplateURLService.  Instead, TestingTemplateURLServiceClient is responsible to implement SetKeywordSearchTermsForURL().
- Remove content::TestBrowserThreadBundle from test util.  Tests are responsible to set up one.  This enables TemplateURLServiceTestSyncTest to use multiple test util instances.

BUG=387985
TEST=unit_tests

Committed: https://crrev.com/3113536e4241cd192680f98b2d1be2b2988b35dd
Cr-Commit-Position: refs/heads/master@{#292597}

[hashimoto, 2014-08-28 09:58:42]

Patchset #1 (id:1) has been deleted

[hashimoto, 2014-08-28 10:07:41]

hashimoto@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2014-08-28 19:06:20]

LGTM

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/search_provider_install_data_unittest.cc
(right):

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/search_provider_install_data_unittest.cc:134:
content::TestBrowserThreadBundle thread_bundle_;
Nit: Add comments about why we need this.

While here, try to make these data members private instead of protected where
possible.

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_service_test_util.h (right):

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:55: // Set the
google base url.  |base_url| must be valid.
Nit: Set -> Sets

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:58: // Set the
managed preferences for the default search provider and trigger
Nit: Set -> Sets

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:60: // URLs,
otherwise use a list containing a single entry.
Nit: use -> uses

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:72: // Remove all
the managed preferences for the default search provider and
Nit: Remove -> Removes

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:73: // trigger
notification.
Nit: trigger -> triggers

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:76: // Returns
the KeywordWebDataService.
Nit: Remove this comment ant the two below, they add nothing to the code

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
File components/search_engines/template_url_fetcher_unittest.cc (right):

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
components/search_engines/template_url_fetcher_unittest.cc:61:
content::TestBrowserThreadBundle thread_bundle_;
Nit: Add comments about why we need this.

While here, try to make these data members private instead of protected where
possible.

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
File components/search_engines/template_url_service_unittest.cc (right):

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
components/search_engines/template_url_service_unittest.cc:168:
content::TestBrowserThreadBundle thread_bundle_;
Nit: Add comments about why we need this.

While here, try to make these data members private instead of protected where
possible.

[hashimoto, 2014-08-29 08:06:27]

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/search_provider_install_data_unittest.cc
(right):

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/search_provider_install_data_unittest.cc:134:
content::TestBrowserThreadBundle thread_bundle_;
On 2014/08/28 19:06:19, Peter Kasting wrote:
> Nit: Add comments about why we need this.
> 
> While here, try to make these data members private instead of protected where
> possible.

Added comments and made all data members private.

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_service_test_util.h (right):

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:55: // Set the
google base url.  |base_url| must be valid.
On 2014/08/28 19:06:19, Peter Kasting wrote:
> Nit: Set -> Sets

Done.

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:58: // Set the
managed preferences for the default search provider and trigger
On 2014/08/28 19:06:19, Peter Kasting wrote:
> Nit: Set -> Sets

Done.

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:60: // URLs,
otherwise use a list containing a single entry.
On 2014/08/28 19:06:20, Peter Kasting wrote:
> Nit: use -> uses

Done.

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:72: // Remove all
the managed preferences for the default search provider and
On 2014/08/28 19:06:19, Peter Kasting wrote:
> Nit: Remove -> Removes

Done.

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:73: // trigger
notification.
On 2014/08/28 19:06:19, Peter Kasting wrote:
> Nit: trigger -> triggers

Done.

https://codereview.chromium.org/513133002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service_test_util.h:76: // Returns
the KeywordWebDataService.
On 2014/08/28 19:06:19, Peter Kasting wrote:
> Nit: Remove this comment ant the two below, they add nothing to the code

Done.

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
File components/search_engines/template_url_fetcher_unittest.cc (right):

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
components/search_engines/template_url_fetcher_unittest.cc:61:
content::TestBrowserThreadBundle thread_bundle_;
On 2014/08/28 19:06:20, Peter Kasting wrote:
> Nit: Add comments about why we need this.
> 
> While here, try to make these data members private instead of protected where
> possible.

Added comments and made all data members private.

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
File components/search_engines/template_url_service_unittest.cc (right):

https://codereview.chromium.org/513133002/diff/20001/components/search_engine...
components/search_engines/template_url_service_unittest.cc:168:
content::TestBrowserThreadBundle thread_bundle_;
On 2014/08/28 19:06:20, Peter Kasting wrote:
> Nit: Add comments about why we need this.
> 
> While here, try to make these data members private instead of protected where
> possible.

Added comments and made all data members private.

[hashimoto, 2014-08-29 08:06:39]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-29 08:07:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/513133002/40001

[hashimoto, 2014-08-29 08:22:40]

Patchset #3 (id:60001) has been deleted

[hashimoto, 2014-08-29 08:23:26]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-29 08:24:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/513133002/80001

[commit-bot: I haz the power, 2014-08-29 09:20:00]

Committed patchset #3 (id:80001) as f1d552caddeff54f3a31d4968acfb6c218d0e34e

[commit-bot: I haz the power, 2014-09-10 03:07:22]

Patchset 3 (id:??) landed as
https://crrev.com/3113536e4241cd192680f98b2d1be2b2988b35dd
Cr-Commit-Position: refs/heads/master@{#292597}