Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: public/web/WebWidget.h

Issue 513053003: Made Blink aware of top controls offset (Blink-side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added top_controls_content_offset Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/WebViewImpl.h ('K') | « public/platform/WebLayerTreeView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebWidget.h
diff --git a/public/web/WebWidget.h b/public/web/WebWidget.h
index d0e12437890840de7d3f096cb11941719c0c1f65..46119a4d8bcb6bc11b5b2332e01028efe9ab5ffc 100644
--- a/public/web/WebWidget.h
+++ b/public/web/WebWidget.h
@@ -75,6 +75,11 @@ public:
// keyboard to overlay over content but allow scrolling it into view.
virtual void resizePinchViewport(const WebSize&) { }
+ // Lets Blink know the updated top controls content offset (i.e. how much
+ // the top controls are showing). Should always be 0 on platforms without
+ // top controls.
+ virtual void setTopControlsContentOffset(float) { }
aelias_OOO_until_Jul13 2014/09/03 19:28:42 Looks like nobody calls this in your Chromium-side
bokan 2014/09/04 23:10:02 Done.
+
// Ends a group of resize events that was started with a call to
// willStartLiveResize.
virtual void willEndLiveResize() { }
@@ -138,11 +143,12 @@ public:
// Check whether the given point hits any registered touch event handlers.
virtual bool hasTouchEventHandlersAt(const WebPoint&) { return true; }
- // Applies a scroll delta to the root layer, which is bundled with a page
- // scale factor that may apply a CSS transform on the whole document (used
- // for mobile-device pinch zooming). This is triggered by events sent to the
- // compositor thread.
- virtual void applyScrollAndScale(const WebSize& scrollDelta, float scaleFactor) { }
+ // Applies viewport related properties during a commit from the compositor
+ // thread.
+ virtual void applyViewportProperties(
+ const WebSize& scrollDelta,
+ float scaleFactor,
+ float topControlsDelta) { }
// Called to inform the WebWidget that mouse capture was lost.
virtual void mouseCaptureLost() { }
« Source/web/WebViewImpl.h ('K') | « public/platform/WebLayerTreeView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698