pkg/polymer/test/build/build_log_combiner_test.dart - Issue 513023002: Step one towards stable error messages with details:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/test/build/build_log_combiner_test.dart

Issue 513023002: Step one towards stable error messages with details: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/polymer/lib/src/build/messages.dart ('K') | « pkg/polymer/test/build/all_phases_test.dart ('k') | pkg/polymer/test/build/common.dart » ('j') | pkg/polymer/tool/create_message_details_page.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/polymer/test/build/build_log_combiner_test.dart

diff --git a/pkg/polymer/test/build/build_log_combiner_test.dart b/pkg/polymer/test/build/build_log_combiner_test.dart

index 6f98e9ac51741dc453080115b1bafae9c39cfa26..7c50dd413d3dc1b8822c78ffb8f5124ab8e9fdfd 100644

--- a/pkg/polymer/test/build/build_log_combiner_test.dart

+++ b/pkg/polymer/test/build/build_log_combiner_test.dart

@@ -4,8 +4,10 @@

library polymer.test.build.build_log_combiner_test;

-import 'package:polymer/src/build/common.dart';

+import 'package:code_transformers/messages/build_logger.dart' show

+ LOG_EXTENSION;

import 'package:polymer/src/build/build_log_combiner.dart';

+import 'package:polymer/src/build/common.dart';

import 'package:unittest/compact_vm_config.dart';

import 'package:unittest/unittest.dart';

@@ -19,17 +21,25 @@ void main() {

testPhases('combines multiple logs', phases, {

'a|web/test.html': '<!DOCTYPE html><html></html>',

- 'a|web/test.html$LOG_EXTENSION.1': '[${_logString('Info', 'foo')}]',

- 'a|web/test.html$LOG_EXTENSION.2': '[${_logString('Warning', 'bar')}]',

- 'a|web/test.html$LOG_EXTENSION.3': '[${_logString('Error', 'baz')}]',

+ 'a|web/test.html$LOG_EXTENSION.1':

+ '{"foo_0":[${_logString('Info', 0, 'foo')}]}',

+ 'a|web/test.html$LOG_EXTENSION.2':

+ '{"foo_2":[${_logString('Warning', 2, 'bar')}]}',

+ 'a|web/test.html$LOG_EXTENSION.3':

+ '{'

+ '"foo_2":[${_logString('Error', 2, 'baz1')}],'

+ '"foo_44":[${_logString('Error', 44, 'baz2')}]'

+ '}',

}, {

'a|web/test.html': '<!DOCTYPE html><html></html>',

- 'a|web/test.html$LOG_EXTENSION':

- '[${_logString('Info', 'foo')},'

- '${_logString('Warning', 'bar')},'

- '${_logString('Error', 'baz')}]',

+ 'a|web/test.html$LOG_EXTENSION': '{'

+ '"foo_0":[${_logString('Info', 0, 'foo')}],'

+ '"foo_2":[${_logString('Warning', 2, 'bar')},'

+ '${_logString('Error', 2, 'baz1')}],'

+ '"foo_44":[${_logString('Error', 44, 'baz2')}]'

+ '}',

});

}

-String _logString(String level, String message) =>

- '{"level":"$level","message":"$message"}';

+String _logString(String level, int id, String message) =>

+ '{"level":"$level","message":{"id":"foo_$id","snippet":"$message"}}';