Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: pkg/polymer/test/build/import_inliner_test.dart

Issue 513023002: Step one towards stable error messages with details: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/test/build/common.dart ('k') | pkg/polymer/test/build/linter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/import_inliner_test.dart
diff --git a/pkg/polymer/test/build/import_inliner_test.dart b/pkg/polymer/test/build/import_inliner_test.dart
index c25958a4b2c2483208a3d72a0b7f721081239866..13b4cdf71617d1604c7cd8d28b7b93aba0213b7b 100644
--- a/pkg/polymer/test/build/import_inliner_test.dart
+++ b/pkg/polymer/test/build/import_inliner_test.dart
@@ -680,20 +680,31 @@ void importTests() {
'</head></html>',
}, {
'a|web/test.html._buildLogs.1':
- '[{'
+ '{"polymer#25":[{'
'"level":"Error",'
- '"message":"${const HtmlEscape().convert(
- 'Failed to inline html import: '
- 'Could not find asset a|web/foo.html.')}",'
- '"assetId":{"package":"a","path":"web/foo.html"},'
+ '"message":{'
+ '"id":"polymer#25",'
+ '"snippet":"Failed to inline HTML import: '
+ 'Could not find asset a|web/foo.html."'
+ '},'
'"span":{'
- '"location":"web/test.html:1:28",'
- '"text":"${const HtmlEscape().convert(
- '<link rel="import" href="foo.html">')}"'
- '}'
- '}]',
+ '"start":{'
+ '"url":"web/test.html",'
+ '"offset":27,'
+ '"line":0,'
+ '"column":27'
+ '},'
+ '"end":{'
+ '"url":"web/test.html",'
+ '"offset":62,'
+ '"line":0,'
+ '"column":62'
+ '},'
+ '"text":"<link rel=\\"import\\" href=\\"foo.html\\">"'
+ '}'
+ '}]}',
}, [
- 'error: Failed to inline html import: '
+ 'error: Failed to inline HTML import: '
'Could not find asset a|web/foo.html. (web/test.html 0 27)',
]);
}
@@ -1022,8 +1033,7 @@ void urlAttributeTests() {
}, {}, [
'warning: When using bindings with the "src" attribute you may '
'experience errors in certain browsers. Please use the "_src" '
- 'attribute instead. For more information, see '
- 'http://goo.gl/5av8cU (web/test.html 0 40)',
+ 'attribute instead. (web/test.html 0 40)',
'warning: The "_href" attribute is only supported when using '
'bindings. Please change to the "href" attribute. '
'(web/test.html 0 63)',
« no previous file with comments | « pkg/polymer/test/build/common.dart ('k') | pkg/polymer/test/build/linter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698