pkg/polymer/test/build/all_phases_test.dart - Issue 513023002: Step one towards stable error messages with details:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/test/build/all_phases_test.dart

Issue 513023002: Step one towards stable error messages with details: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer/test/build/all_phases_test.dart

diff --git a/pkg/polymer/test/build/all_phases_test.dart b/pkg/polymer/test/build/all_phases_test.dart

index 869a98f8cd95304b3c018c27e99a35e25e1c20fb..80efec72d68f11d10f62dbc6c1c77f802b9ebe4d 100644

--- a/pkg/polymer/test/build/all_phases_test.dart

+++ b/pkg/polymer/test/build/all_phases_test.dart

@@ -6,8 +6,7 @@ library polymer.test.build.all_phases_test;

import 'package:code_transformers/tests.dart' show testingDartSdkDirectory;

import 'package:polymer/src/build/common.dart';

-import 'package:polymer/src/build/linter.dart' show USE_POLYMER_HTML,

- USE_INIT_DART, ONLY_ONE_TAG;

+import 'package:polymer/src/build/messages.dart';

import 'package:polymer/src/build/script_compactor.dart' show MAIN_HEADER;

import 'package:polymer/transformer.dart';

import 'package:smoke/codegen/generator.dart' show DEFAULT_IMPORTS;

@@ -23,7 +22,7 @@ void main() {

testPhases('no changes', phases, {

'a|web/test.html': '<!DOCTYPE html><html></html>',

}, {}, [

- 'warning: $USE_INIT_DART'

+ 'warning: ${MISSING_INIT_POLYMER.snippet}'

]);

testPhases('observable changes', phases, {

@@ -175,9 +174,9 @@ void main() {

}, [

// These should not be emitted multiple times. See:

// https://code.google.com/p/dart/issues/detail?id=17197

- 'warning: $ONLY_ONE_TAG (web/test.html 2 0)',

- 'warning: $ONLY_ONE_TAG (web/test.html 18 0)',

- 'warning: $ONLY_ONE_TAG (web/test.html 34 0)',

+ 'warning: ${ONLY_ONE_TAG.snippet} (web/test.html 2 0)',

+ 'warning: ${ONLY_ONE_TAG.snippet} (web/test.html 18 0)',

+ 'warning: ${ONLY_ONE_TAG.snippet} (web/test.html 34 0)',

'warning: Script file at "d.dart" not found. (web/test.html 34 0)',

]);

« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | pkg/polymer/test/build/build_log_combiner_test.dart » ('j') | no next file with comments »